Sign upLogin

taylor1791/promissory-arbiter

View on GitHub
Star
src/promissory-arbiter.js

Summary

Maintainability
F
1 wk
Test Coverage

Function factory has a Cognitive Complexity of 177 (exceeds 5 allowed). Consider refactoring.
Open

}(this, function factory () {
  'use strict';

  return create();
Severity: Minor
Found in src/promissory-arbiter.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 624 lines of code (exceeds 25 allowed). Consider refactoring.
Open

}(this, function factory () {
  'use strict';

  return create();
Severity: Major
Found in src/promissory-arbiter.js - About 3 days to fix

    File promissory-arbiter.js has 637 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    (function iife (root, factory) {
  'use strict';

  var moduleName = 'Arbiter';
    Severity: Major
    Found in src/promissory-arbiter.js - About 1 day to fix

      Consider simplifying this complex logical expression.
      Open

          if (!settlementLatch && latch >= 1 && fulfilled >= latch
      || !settlementLatch && latch < 1 && fulfilled / total >= latch
      || settlementLatch && latch >= 1 && settled >= latch
      || settlementLatch && latch < 1 && settled / total >= latch
    ) {
      Severity: Critical
      Found in src/promissory-arbiter.js - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

            if (!settlementLatch && latch >= 1 && maxFulfilled < latch
      || !settlementLatch && latch < 1 && maxFulfilled / total < latch
      || settlementLatch && latch >= 1 && total < latch
      || settlementLatch && latch < 1 && total === 0
    ) {
        Severity: Critical
        Found in src/promissory-arbiter.js - About 2 hrs to fix

          Function evaluateLatch has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function evaluateLatch (resolver, options) {
    var
      settlementLatch = options.settlementLatch,
      latch = options.latch,
      promise = resolver.promise,
          Severity: Minor
          Found in src/promissory-arbiter.js - About 1 hr to fix

            Function subscribe has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              function subscribe (state, topic, subscription, options, context) {
    assert(typeof topic, 'string', 'Arbiter.subscribe', 'strings', 'topics');
    options = merge(state.options, options);

    var
            Severity: Minor
            Found in src/promissory-arbiter.js - About 1 hr to fix

              Function resumeSubscriptionDispatcher has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  topic, data, options, subscriptions, resolver, fulfill, reject
              Severity: Major
              Found in src/promissory-arbiter.js - About 50 mins to fix

                Function searchAround has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    getValue, getConditionValue, value, conditionValue, i, arr
                Severity: Minor
                Found in src/promissory-arbiter.js - About 45 mins to fix

                  Function subscribeDispatcher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    function subscribeDispatcher (state, topic, subscriptions, options, context) {
                  Severity: Minor
                  Found in src/promissory-arbiter.js - About 35 mins to fix

                    Function findLineage has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                      function findLineage (getValue, isAncestor, value, tree, path) {
                    Severity: Minor
                    Found in src/promissory-arbiter.js - About 35 mins to fix

                      Function assert has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        function assert (value, expected, method, type, identifier) {
                      Severity: Minor
                      Found in src/promissory-arbiter.js - About 35 mins to fix

                        Function subscribe has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          function subscribe (state, topic, subscription, options, context) {
                        Severity: Minor
                        Found in src/promissory-arbiter.js - About 35 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return !!node.subscriptions.splice(i, 1);
                          Severity: Major
                          Found in src/promissory-arbiter.js - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                if (!settlementLatch && latch >= 1 && fulfilled >= latch
      || !settlementLatch && latch < 1 && fulfilled / total >= latch
      || settlementLatch && latch >= 1 && settled >= latch
      || settlementLatch && latch < 1 && settled / total >= latch
                            Severity: Major
                            Found in src/promissory-arbiter.js and 1 other location - About 1 hr to fix
                            src/promissory-arbiter.js on lines 569..572

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 66.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                if (!settlementLatch && latch >= 1 && maxFulfilled < latch
      || !settlementLatch && latch < 1 && maxFulfilled / total < latch
      || settlementLatch && latch >= 1 && total < latch
      || settlementLatch && latch < 1 && total === 0
                            Severity: Major
                            Found in src/promissory-arbiter.js and 1 other location - About 1 hr to fix
                            src/promissory-arbiter.js on lines 578..581

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 66.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status