Sign upLogin

teableio/teable

View on GitHub
Star
apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts
04c6aea2

Summary

Maintainability
D
1 day
Test Coverage

File view-open-api.service.ts has 570 lines of code (exceeds 300 allowed). Consider refactoring.
Open

import {
  BadRequestException,
  Injectable,
  Logger,
  NotFoundException,
Severity: Major
Found in apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts - About 1 day to fix

    ViewOpenApiService has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Injectable()
export class ViewOpenApiService {
  private logger = new Logger(ViewOpenApiService.name);

  constructor(
    Severity: Minor
    Found in apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts - About 2 hrs to fix

      Function collectFilterLinkFieldRecords has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        private async collectFilterLinkFieldRecords(
    linkFields: Record<string, string>,
    filter?: IFilter
  ) {
    if (!filter || !filter.filterSet) {
      Severity: Minor
      Found in apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function manualSort has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        @Timing()
  async manualSort(tableId: string, viewId: string, viewOrderRo: IManualSortRo) {
    const { sortObjs } = viewOrderRo;
    const dbTableName = await this.recordService.getDbTableName(tableId);
    const fields = await this.fieldService.getFieldsByQuery(tableId, { viewId });
      Severity: Minor
      Found in apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getFilterLinkRecordsByTable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        async getFilterLinkRecordsByTable(tableId: string, filter?: IFilter) {
    if (!filter) {
      return [];
    }
    const linkFields = await this.prismaService.field.findMany({
      Severity: Minor
      Found in apps/nestjs-backend/src/features/view/open-api/view-open-api.service.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status