Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/features/bonus/cgn/screens/CgnDetailScreen.tsx
55fa198d

Summary

Maintainability
D
2 days
Test Coverage

Function CgnDetailScreen has 185 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const CgnDetailScreen = (props: Props): React.ReactElement => {
  const headerHeight = useHeaderHeight();
  const [cardLoading, setCardLoading] = useState(true);
  const navigation =
    useNavigation<IOStackNavigationProp<CgnDetailsParamsList, "CGN_DETAILS">>();
Severity: Major
Found in ts/features/bonus/cgn/screens/CgnDetailScreen.tsx - About 7 hrs to fix

    File CgnDetailScreen.tsx has 285 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as pot from "@pagopa/ts-commons/lib/pot";
import { useNavigation } from "@react-navigation/native";
import React, { useState } from "react";
import { View } from "react-native";
import { connect } from "react-redux";
    Severity: Minor
    Found in ts/features/bonus/cgn/screens/CgnDetailScreen.tsx - About 2 hrs to fix

      Function CgnDetailScreen has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      const CgnDetailScreen = (props: Props): React.ReactElement => {
  const headerHeight = useHeaderHeight();
  const [cardLoading, setCardLoading] = useState(true);
  const navigation =
    useNavigation<IOStackNavigationProp<CgnDetailsParamsList, "CGN_DETAILS">>();
      Severity: Minor
      Found in ts/features/bonus/cgn/screens/CgnDetailScreen.tsx - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

        const scrollHandler = useAnimatedScrollHandler(
    ({ contentOffset, layoutMeasurement, contentSize }) => {
      // eslint-disable-next-line functional/immutable-data
      scrollTranslationY.value = contentOffset.y;
      Severity: Major
      Found in ts/features/bonus/cgn/screens/CgnDetailScreen.tsx and 3 other locations - About 3 hrs to fix
      ts/components/BonusCard/BonusCardScreenComponent.tsx on lines 124..136
      ts/features/bonus/cgn/screens/merchants/CgnMerchantDetailScreen.tsx on lines 122..134
      ts/features/bonus/common/components/BonusInformationComponent.tsx on lines 204..216

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

        const bottomMargin: number = React.useMemo(
    () =>
      safeAreaInsets.bottom === 0
        ? IOVisualCostants.appMarginDefault
        : safeAreaInsets.bottom,
      Severity: Major
      Found in ts/features/bonus/cgn/screens/CgnDetailScreen.tsx and 3 other locations - About 35 mins to fix
      ts/components/BonusCard/BonusCardScreenComponent.tsx on lines 71..77
      ts/features/bonus/cgn/screens/merchants/CgnMerchantDetailScreen.tsx on lines 79..85
      ts/features/bonus/common/components/BonusInformationComponent.tsx on lines 138..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status