Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/screens/authentication/cie/CieCardReaderScreen.tsx
55fa198d

Summary

Maintainability
C
1 day
Test Coverage

File CieCardReaderScreen.tsx has 490 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * A screen to guide the user to proper read the CIE
 * TODO: isolate cie event listener as saga
 * TODO: when 100% is reached, the animation end
 */
Severity: Minor
Found in ts/screens/authentication/cie/CieCardReaderScreen.tsx - About 7 hrs to fix

    Function startCieiOS has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public async startCieiOS(useCieUat: boolean) {
    cieManager.removeAllListeners();
    cieManager.onEvent(this.handleCieEvent);
    cieManager.onError(this.handleCieError);
    cieManager.onSuccess(this.handleCieSuccess);
    Severity: Minor
    Found in ts/screens/authentication/cie/CieCardReaderScreen.tsx - About 1 hr to fix

      Function getTextForState has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const getTextForState = (
  state: ReadingState.waiting_card | ReadingState.error,
  errorMessage: string = ""
): TextForState => {
  const texts: Record<
      Severity: Minor
      Found in ts/screens/authentication/cie/CieCardReaderScreen.tsx - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  primary={{
            type: "Outline",
            buttonProps: {
              label: I18n.t("global.buttons.cancel"),
              accessibilityLabel: I18n.t("global.buttons.cancel"),
        Severity: Minor
        Found in ts/screens/authentication/cie/CieCardReaderScreen.tsx and 1 other location - About 55 mins to fix
        ts/screens/authentication/cie/CieCardReaderScreen.tsx on lines 475..482

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  primary={{
            type: "Outline",
            buttonProps: {
              label: I18n.t("global.buttons.cancel"),
              accessibilityLabel: I18n.t("global.buttons.cancel"),
        Severity: Minor
        Found in ts/screens/authentication/cie/CieCardReaderScreen.tsx and 1 other location - About 55 mins to fix
        ts/screens/authentication/cie/CieCardReaderScreen.tsx on lines 488..495

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status