Sorry, data for that comparison is no longer available.
Sign upLogin

teamdigitale/italia-app

View on GitHub
Star
ts/store/reducers/authentication.ts

Summary

Maintainability
C
1 day
Test Coverage

Function reducer has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const reducer = (
  state: AuthenticationState = INITIAL_STATE,
  action: Action
  // eslint-disable-next-line sonarjs/cognitive-complexity
): AuthenticationState => {
Severity: Major
Found in ts/store/reducers/authentication.ts - About 3 hrs to fix

    File authentication.ts has 265 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as O from "fp-ts/lib/Option";
import { PersistPartial } from "redux-persist";
import { createSelector } from "reselect";
import { isActionOf } from "typesafe-actions";
import { PublicSession } from "../../../definitions/backend/PublicSession";
    Severity: Minor
    Found in ts/store/reducers/authentication.ts - About 2 hrs to fix

      Function reducer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      const reducer = (
  state: AuthenticationState = INITIAL_STATE,
  action: Action
  // eslint-disable-next-line sonarjs/cognitive-complexity
): AuthenticationState => {
      Severity: Minor
      Found in ts/store/reducers/authentication.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return {
      ...state,
      ...{
        kind: "LogoutRequested",
        reason: "NOT_LOGGED_IN"
      Severity: Major
      Found in ts/store/reducers/authentication.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return {
      kind: "LoggedOutWithIdp",
      idp: state.idp,
      reason: isActionOf(sessionExpired, action)
        ? "SESSION_EXPIRED"
        Severity: Major
        Found in ts/store/reducers/authentication.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return {
      ...state,
      ...{
        sessionToken: action.payload
      }
          Severity: Major
          Found in ts/store/reducers/authentication.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return INITIAL_STATE;
            Severity: Major
            Found in ts/store/reducers/authentication.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return {
      ...state,
      ...{
        kind: "LoggedInWithSessionInfo",
        sessionInfo: action.payload
              Severity: Major
              Found in ts/store/reducers/authentication.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return state;
                Severity: Major
                Found in ts/store/reducers/authentication.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return {
      kind: "LoggedInWithoutSessionInfo",
      idp: state.idp,
      sessionToken: action.payload.token
    };
                  Severity: Major
                  Found in ts/store/reducers/authentication.ts - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export const walletTokenSelector = (state: GlobalState): string | undefined =>
  isLoggedInWithSessionInfo(state.authentication)
    ? state.authentication.sessionInfo.walletToken
    : undefined;
                    Severity: Minor
                    Found in ts/store/reducers/authentication.ts and 1 other location - About 55 mins to fix
                    ts/store/reducers/authentication.ts on lines 184..187

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    export const zendeskTokenSelector = (state: GlobalState): string | undefined =>
  isLoggedInWithSessionInfo(state.authentication)
    ? state.authentication.sessionInfo.zendeskToken
    : undefined;
                    Severity: Minor
                    Found in ts/store/reducers/authentication.ts and 1 other location - About 55 mins to fix
                    ts/store/reducers/authentication.ts on lines 189..192

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status