techvision/brails4

View on GitHub
app/assets/javascripts/tabPanel.js

Summary

Maintainability
D
2 days
Test Coverage

File tabPanel.js has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

$(document).ready(function() {
  var panel1 = new tabpanel("tabpanel1", false);
});

//
Severity: Minor
Found in app/assets/javascripts/tabPanel.js - About 2 hrs to fix

    Function handleTabKeyDown has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    tabpanel.prototype.handleTabKeyDown = function($tab, e) {
    
      if (e.altKey) {
        // do nothing
        return true;
    Severity: Major
    Found in app/assets/javascripts/tabPanel.js - About 2 hrs to fix

      Function handlePanelKeyDown has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      tabpanel.prototype.handlePanelKeyDown = function($elem, e) {
      
        if (e.altKey) {
          // do nothing
          return true;
      Severity: Major
      Found in app/assets/javascripts/tabPanel.js - About 2 hrs to fix

        Function handlePanelKeyDown has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        tabpanel.prototype.handlePanelKeyDown = function($elem, e) {
        
          if (e.altKey) {
            // do nothing
            return true;
        Severity: Minor
        Found in app/assets/javascripts/tabPanel.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleTabKeyDown has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        tabpanel.prototype.handleTabKeyDown = function($tab, e) {
        
          if (e.altKey) {
            // do nothing
            return true;
        Severity: Minor
        Found in app/assets/javascripts/tabPanel.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function focusable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          focusable: function(element) {
            var nodeName = element.nodeName.toLowerCase();
            var tabIndex = $(element).attr('tabindex');
        
            // the element and all of its ancestors must be visible
        Severity: Minor
        Found in app/assets/javascripts/tabPanel.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return false;
        Severity: Major
        Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return false;
          Severity: Major
          Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return true;
            Severity: Major
            Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return true;
              Severity: Major
              Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return false;
                Severity: Major
                Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return false;
                  Severity: Major
                  Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return false;
                    Severity: Major
                    Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return false;
                      Severity: Major
                      Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                          return true;
                        Severity: Major
                        Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return true;
                          Severity: Major
                          Found in app/assets/javascripts/tabPanel.js - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                case this.keys.end: {
                            
                                  // switch to the last tab
                                  this.switchTabs($tab, this.$tabs.last());
                            
                            Severity: Minor
                            Found in app/assets/javascripts/tabPanel.js and 1 other location - About 55 mins to fix
                            app/assets/javascripts/tabPanel.js on lines 299..306

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 53.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                case this.keys.home: {
                            
                                  // switch to the first tab
                                  this.switchTabs($tab, this.$tabs.first());
                            
                            Severity: Minor
                            Found in app/assets/javascripts/tabPanel.js and 1 other location - About 55 mins to fix
                            app/assets/javascripts/tabPanel.js on lines 307..314

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 53.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                              this.$panel.find('#' + $tab.attr('aria-controls')).show().attr('aria-hidden', 'false');
                            Severity: Minor
                            Found in app/assets/javascripts/tabPanel.js and 1 other location - About 30 mins to fix
                            app/assets/javascripts/tabPanel.js on lines 128..128

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                this.$panel.find('#' + $newTab.attr('aria-controls')).show().attr('aria-hidden', 'false');
                            Severity: Minor
                            Found in app/assets/javascripts/tabPanel.js and 1 other location - About 30 mins to fix
                            app/assets/javascripts/tabPanel.js on lines 89..89

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 45.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status