Sign upLogin

techvision/brails4

View on GitHub
Star
app/assets/javascripts/ytp.js

Summary

Maintainability
F
5 days
Test Coverage

File ytp.js has 492 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*********************************** 
  Accessible Controls for the YouTube Embedded Video Player
  Copyright (c) 2010 Ken Petri, Web Accessibility Center, The Ohio State University
  
  ** Licensing **
Severity: Minor
Found in app/assets/javascripts/ytp.js - About 7 hrs to fix

    Function ytPlayerInit has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ytPlayerInit(list,aspect,ytp,pid)
{
  var width = "480";
  if (aspect == "normal") 
  {
    Severity: Major
    Found in app/assets/javascripts/ytp.js - About 2 hrs to fix

      Function ytPlayerDispatch has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function ytPlayerDispatch(ytp,ytpid) 
{
  if (ytp) 
  {
    // get movie urls, titles, and other set up variables from page
      Severity: Minor
      Found in app/assets/javascripts/ytp.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ytPlayerDispatch has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function ytPlayerDispatch(ytp,ytpid) 
{
  if (ytp) 
  {
    // get movie urls, titles, and other set up variables from page
      Severity: Minor
      Found in app/assets/javascripts/ytp.js - About 1 hr to fix

        Function ytvoldown has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        function ytvoldown(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
        Severity: Minor
        Found in app/assets/javascripts/ytp.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function ytvolup has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        function ytvolup(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
        Severity: Minor
        Found in app/assets/javascripts/ytp.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function ytAddLoadListener has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function ytAddLoadListener(fn){
  if (typeof window.addEventListener != 'undefined') 
  {
    window.addEventListener('load', fn, false);
  }
        Severity: Minor
        Found in app/assets/javascripts/ytp.js - About 1 hr to fix

          Function ytPlayerBoxDraw has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function ytPlayerBoxDraw(aspect,ytpbox,pid)
{
  var width = "480px";
  if (aspect == "normal") 
  {
          Severity: Minor
          Found in app/assets/javascripts/ytp.js - About 1 hr to fix

            Function ytPlayerInit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            function ytPlayerInit(list,aspect,ytp,pid)
{
  var width = "480";
  if (aspect == "normal") 
  {
            Severity: Minor
            Found in app/assets/javascripts/ytp.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function ytvoldown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function ytvoldown(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
            Severity: Minor
            Found in app/assets/javascripts/ytp.js - About 1 hr to fix

              Function ytvolup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function ytvolup(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
              Severity: Minor
              Found in app/assets/javascripts/ytp.js - About 1 hr to fix

                Function ytAttachEventListener has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function ytAttachEventListener(target, eventType, functionRef, capture)
{
  if (typeof target.addEventListener != "undefined") 
  {
    target.addEventListener(eventType, functionRef, capture);
                Severity: Minor
                Found in app/assets/javascripts/ytp.js - About 1 hr to fix

                  Function updateButtonState has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function updateButtonState(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id))
  {
                  Severity: Minor
                  Found in app/assets/javascripts/ytp.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function ytAddLoadListener has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function ytAddLoadListener(fn){
  if (typeof window.addEventListener != 'undefined') 
  {
    window.addEventListener('load', fn, false);
  }
                  Severity: Minor
                  Found in app/assets/javascripts/ytp.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function ytback has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function ytback(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id))
  {
                  Severity: Minor
                  Found in app/assets/javascripts/ytp.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function ytforward has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function ytforward(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
                  Severity: Minor
                  Found in app/assets/javascripts/ytp.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function ytAttachEventListener has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function ytAttachEventListener(target, eventType, functionRef, capture)
{
  if (typeof target.addEventListener != "undefined") 
  {
    target.addEventListener(eventType, functionRef, capture);
                  Severity: Minor
                  Found in app/assets/javascripts/ytp.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function ytvoldown(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
                  Severity: Major
                  Found in app/assets/javascripts/ytp.js and 1 other location - About 7 hrs to fix
                  app/assets/javascripts/ytp.js on lines 370..399

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 189.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  function ytvolup(ytpid)
{
  var ytp = document.getElementById("thisytp"+ytpid);
  if (new RegExp('^(' + ytplayer.join('|') + ')$').test(ytp.id)) 
  {
                  Severity: Major
                  Found in app/assets/javascripts/ytp.js and 1 other location - About 7 hrs to fix
                  app/assets/javascripts/ytp.js on lines 400..429

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 189.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status