Sign upLogin

telepat-io/telepat-api

View on GitHub
Star
controllers/security.js

Summary

Maintainability
D
1 day
Test Coverage

Function objectACL has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

security.objectACL = function (accessControl) {
    return function(req, res, next) {
        if (!req.body || !Object.getOwnPropertyNames(req.body).length) {
            return next(new Models.TelepatError(Models.TelepatError.errors.RequestBodyEmpty));
        }
Severity: Minor
Found in controllers/security.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function objectACL has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

security.objectACL = function (accessControl) {
    return function(req, res, next) {
        if (!req.body || !Object.getOwnPropertyNames(req.body).length) {
            return next(new Models.TelepatError(Models.TelepatError.errors.RequestBodyEmpty));
        }
Severity: Minor
Found in controllers/security.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

                    return next(new Models.TelepatError(Models.TelepatError.errors.OperationNotAllowed));
    Severity: Major
    Found in controllers/security.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return next(new Models.TelepatError(Models.TelepatError.errors.OperationNotAllowed));
      Severity: Major
      Found in controllers/security.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return next(new Models.TelepatError(Models.TelepatError.errors.AuthorizationMissing));
        Severity: Major
        Found in controllers/security.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return next(new Models.TelepatError(Models.TelepatError.errors.ApplicationHasNoSchema));
          Severity: Major
          Found in controllers/security.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return next(Models.TelepatError(Models.TelepatError.errors.OperationNotAllowed));
            Severity: Major
            Found in controllers/security.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                                  return verifyAndSetUser(req, next, acl);
              Severity: Major
              Found in controllers/security.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return next(new Models.TelepatError(Models.TelepatError.errors.ApplicationSchemaModelNotFound,
                [req._telepat.applicationId, mdl]));
                Severity: Major
                Found in controllers/security.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return next(new Models.TelepatError(Models.TelepatError.errors.InvalidAuthorization,
                        ['authorization header field is not formed well']));
                  Severity: Major
                  Found in controllers/security.js - About 30 mins to fix

                    Function applicationIdValidation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    security.applicationIdValidation = function(req, res, next) {
    if (!req.get('X-BLGREQ-APPID'))
        return next(new Models.TelepatError(Models.TelepatError.errors.ApplicationIdMissing));
    else {
        if (!Models.Application.loadedAppModels[req.get('X-BLGREQ-APPID')]) {
                    Severity: Minor
                    Found in controllers/security.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (Models.Application.loadedAppModels[appId].admins.indexOf(req.user.id) === -1) {
        return next(new Models.TelepatError(Models.TelepatError.errors.ApplicationForbidden));
    }
                    Severity: Major
                    Found in controllers/security.js and 1 other location - About 1 hr to fix
                    controllers/admin/app.js on lines 118..120

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 72.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (req._telepat)
            req._telepat.device_id = req.get('X-BLGREQ-UDID');
        else
            req._telepat = {device_id: req.get('X-BLGREQ-UDID')};
                    Severity: Major
                    Found in controllers/security.js and 1 other location - About 1 hr to fix
                    controllers/security.js on lines 74..77

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if (req._telepat)
            req._telepat.applicationId = req.get('X-BLGREQ-APPID');
        else
            req._telepat = {applicationId: req.get('X-BLGREQ-APPID')};
                    Severity: Major
                    Found in controllers/security.js and 1 other location - About 1 hr to fix
                    controllers/security.js on lines 57..60

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 57.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status