Sign upLogin

thbar/rails-recurly-js-sample-application

View on GitHub
Star

Showing 2 of 2 total issues

Method confirm_subscription has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def confirm_subscription(user, token)
    subscription = Recurly.js.fetch(token)
    return false unless subscription.is_a?(Recurly::Subscription)
    account = subscription.account
    return false unless account.account_code == user.recurly_account_code
Severity: Minor
Found in app/services/billing_service.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return true
Severity: Major
Found in app/services/billing_service.rb - About 30 mins to fix
    Severity
    Category
    Status
    Source
    Language