Showing 7 of 10 total issues
File machinerry.py
has 524 lines of code (exceeds 250 allowed). Consider refactoring. Open
import cherrypy
import threading
import datetime
Function run
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
def run(self):
"""Continuously run self.execute(). Errors are trapped and logged."""
try:
try:
get_ident = threading.get_ident
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
BoneMachine
has 26 functions (exceeds 20 allowed). Consider refactoring. Open
class BoneMachine(object):
"""Internal subclass which provides the bulk of the machine framework.
You should use the Machine class directly."""
Function _become_paused
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def _become_paused(self, paused, set_state=True):
if self.machine_state != self.PAUSED and paused:
assert self.paused, (
'cannot set machine into paused state without pause flag '
'also being set'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function _reschedule
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def _reschedule(self, on_error):
# Run times might be set by subclasses, so don't override
# anything explicit.
if self.run_time_next is not None:
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function pause_time_text
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def pause_time_text(self):
pause_secs = max((self.now() - self.pause_time).seconds, 1)
mins, secs = divmod(pause_secs, 60)
hours, mins = divmod(mins, 60)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function run_once
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def run_once(self):
"""Run self.execute() once. Errors are trapped.
This is the equivalent of performing a single run immediately in
the context of the machine (with regard to all the prep work which
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"