theEmelie/ramverk1-modul

View on GitHub

Showing 7 of 83 total issues

Method indexActionPost has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function indexActionPost()
    {
        $title = "Väderprognos";
        $request = $this->di->get("request");
        $page = $this->di->get("page");
Severity: Minor
Found in src/IpController/GeoWeatherController.php - About 1 hr to fix

    Function indexActionPost has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function indexActionPost()
        {
            $title = "Väderprognos";
            $request = $this->di->get("request");
            $page = $this->di->get("page");
    Severity: Minor
    Found in src/IpController/GeoWeatherController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function validate($ips)
        {
            $valid = "";
            $domain = "";
            $status = "";
    Severity: Minor
    Found in src/Models/IpValidate.php - About 1 hr to fix

      Method getWeatherGeo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getWeatherGeo($lat, $long, $weather)
          {
              $accessKey = $this->keys['darksky'];
      
              if ($weather == "futureWeather") {
      Severity: Minor
      Found in src/Models/Weather.php - About 1 hr to fix

        Method multiCurl has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function multiCurl($urls)
            {
                $cHandles = [];
        
                //create the multiple cURL handle
        Severity: Minor
        Found in src/Models/Curl.php - About 1 hr to fix

          Function getWeatherGeo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getWeatherGeo($lat, $long, $weather)
              {
                  $accessKey = $this->keys['darksky'];
          
                  if ($weather == "futureWeather") {
          Severity: Minor
          Found in src/Models/Weather.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getWeather has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getWeather($location, $futureOrPast)
              {
                  $lat = "";
                  $long = "";
                  $json = $this->ipstack->validate($location);
          Severity: Minor
          Found in src/IpController/GeoWeatherJsonController.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language