Sign upLogin

theforeman/foreman_remote_execution

View on GitHub
Star
webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js

Summary

Maintainability
D
2 days
Test Coverage

File AdvancedFields.test.js has 377 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable max-lines */
import React from 'react';
import { Provider } from 'react-redux';
import { mount } from '@theforeman/test';
import { fireEvent, screen, render, act } from '@testing-library/react';
Severity: Minor
Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js - About 5 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          } else if (action.key === 'JOB_TEMPLATE') {
        handleSuccess &&
          handleSuccess({
            data: {
              ...jobTemplateResponse,
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 1 other location - About 3 hrs to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 326..361

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          } else if (action.key === 'JOB_TEMPLATE') {
        handleSuccess &&
          handleSuccess({
            data: {
              ...jobTemplateResponse,
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 1 other location - About 3 hrs to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 268..287

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 11 locations. Consider refactoring.
    Open

        render(
      <MockedProvider mocks={gqlMock} addTypename={false}>
        <Provider store={store}>
          <JobWizard />
        </Provider>
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 10 other locations - About 1 hr to fix
    webpack/JobWizard/__tests__/integration.test.js on lines 90..96
    webpack/JobWizard/__tests__/validation.test.js on lines 32..38
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 103..109
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 19..25
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 111..117
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 143..149
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 167..173
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 186..192
    webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js on lines 16..22
    webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 11 locations. Consider refactoring.
    Open

        render(
      <MockedProvider mocks={gqlMock} addTypename={false}>
        <Provider store={store}>
          <JobWizard />
        </Provider>
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 10 other locations - About 1 hr to fix
    webpack/JobWizard/__tests__/integration.test.js on lines 90..96
    webpack/JobWizard/__tests__/validation.test.js on lines 32..38
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 180..186
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 19..25
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 111..117
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 143..149
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 167..173
    webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 186..192
    webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js on lines 16..22
    webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js on lines 54..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                  template_inputs: [
                {
                  name: 'command',
                  required: true,
                  input_type: 'user',
    Severity: Minor
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 1 other location - About 55 mins to fix
    webpack/JobWizard/__tests__/fixtures.js on lines 98..110

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      beforeEach(() => {
    jest.spyOn(selectors, 'selectRouterSearch');
    selectors.selectRouterSearch.mockImplementation(() => ({
      'host_ids[]': ['105', '37'],
    }));
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 2 other locations - About 50 mins to fix
    webpack/JobWizard/__tests__/integration.test.js on lines 21..26
    webpack/JobWizard/steps/Schedule/__tests__/Schedule.test.js on lines 62..67

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        await act(async () => {
      fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
    });
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 5 other locations - About 45 mins to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 187..190
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 222..225
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 295..298
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 369..372
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 389..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        await act(async () => {
      fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
    });
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 5 other locations - About 45 mins to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 110..113
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 187..190
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 295..298
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 369..372
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 389..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        await act(async () => {
      fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
    });
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 5 other locations - About 45 mins to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 110..113
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 187..190
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 222..225
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 295..298
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 389..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        await act(async () => {
      fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
    });
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 5 other locations - About 45 mins to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 110..113
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 222..225
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 295..298
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 369..372
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 389..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        await act(async () => {
      fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
    });
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 5 other locations - About 45 mins to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 110..113
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 187..190
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 222..225
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 369..372
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 389..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 6 locations. Consider refactoring.
    Open

        await act(async () => {
      fireEvent.click(screen.getByText(WIZARD_TITLES.advanced));
      jest.advanceTimersByTime(1000); // to handle pf4 date picker popover
    });
    Severity: Major
    Found in webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js and 5 other locations - About 45 mins to fix
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 110..113
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 187..190
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 222..225
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 295..298
    webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 369..372

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status