Sign upLogin

theforeman/foreman_remote_execution

View on GitHub
Star
webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js

Summary

Maintainability
A
2 hrs
Test Coverage

Identical blocks of code found in 11 locations. Consider refactoring.
Open

    render(
      <MockedProvider mocks={gqlMock} addTypename={false}>
        <Provider store={store}>
          <JobWizard />
        </Provider>
Severity: Major
Found in webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js and 10 other locations - About 1 hr to fix
webpack/JobWizard/__tests__/integration.test.js on lines 90..96
webpack/JobWizard/__tests__/validation.test.js on lines 32..38
webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 103..109
webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 180..186
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 19..25
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 111..117
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 143..149
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 167..173
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 186..192
webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js on lines 54..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 11 locations. Consider refactoring.
Open

    render(
      <MockedProvider mocks={gqlMock} addTypename={false}>
        <Provider store={store}>
          <JobWizard />
        </Provider>
Severity: Major
Found in webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js and 10 other locations - About 1 hr to fix
webpack/JobWizard/__tests__/integration.test.js on lines 90..96
webpack/JobWizard/__tests__/validation.test.js on lines 32..38
webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 103..109
webpack/JobWizard/steps/AdvancedFields/__tests__/AdvancedFields.test.js on lines 180..186
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 19..25
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 111..117
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 143..149
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 167..173
webpack/JobWizard/steps/HostsAndInputs/__tests__/HostsAndInputs.test.js on lines 186..192
webpack/JobWizard/steps/HostsAndInputs/__tests__/TemplateInputs.test.js on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status