Sign upLogin

theforeman/foreman_remote_execution

View on GitHub
Star
webpack/react_app/redux/actions/jobInvocations/index.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function getJobInvocations has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

const getJobInvocations = url => async (dispatch, getState) => {
  function onGetJobInvocationsSuccess({ data }) {
    // If the job has finished, stop polling
    if (data.finished) {
      dispatch({
Severity: Minor
Found in webpack/react_app/redux/actions/jobInvocations/index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getJobInvocations has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getJobInvocations = url => async (dispatch, getState) => {
  function onGetJobInvocationsSuccess({ data }) {
    // If the job has finished, stop polling
    if (data.finished) {
      dispatch({
Severity: Minor
Found in webpack/react_app/redux/actions/jobInvocations/index.js - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status