Showing 322 of 581 total issues
Method no_published_certificate_exists
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def no_published_certificate_exists
documentation_url = params[:dataset][:documentationUrl]
return unless documentation_url.present?
existing_dataset = Dataset.where(documentation_url: documentation_url).first
if existing_dataset.try(:certificate).present?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method deep_merge!
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def deep_merge!(hash, other_hash)
other_hash.each_pair do |current_key, other_value|
this_value = hash[current_key]
hash[current_key] = if this_value.is_a?(Hash) && other_value.is_a?(Hash)
deep_merge!(this_value, other_value)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"