Sign upLogin

threefunkymonkeys/chist

View on GitHub
Star

Showing 9 of 15 total issues

Method parse has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def self.parse(log)
    time_regexp = /^.*\s*\[\d+:\d{2}\s*[AMP]{2}*\]\s*/

    #scan for participants
    participants = log.each_line.grep(/.+\s\[\d{1,2}:\d{1,2}\s*[AMP]{0,2}\].+/).collect{ |capture| capture.split(" [").first }.uniq
Severity: Minor
Found in lib/parser/slack_parser.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.parse(log)
    time_regexp = /^.*\s*\[\d+:\d{2}\s*[AMP]{2}*\]\s*/

    #scan for participants
    participants = log.each_line.grep(/.+\s\[\d{1,2}:\d{1,2}\s*[AMP]{0,2}\].+/).collect{ |capture| capture.split(" [").first }.uniq
Severity: Minor
Found in lib/parser/slack_parser.rb - About 1 hr to fix

    Method to_signup_hash has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def to_signup_hash
      {
        uid:   uid || '',
        name:  self.respond_to?(:extra) && extra.respond_to?(:name) && !extra.name.empty? ? extra.name : \
              (self.respond_to?(:info) && info.respond_to?(:name) && !info.name.empty? ? info.name : ''),
    Severity: Minor
    Found in lib/omniauth_auth_hash.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def call
      if @user
        return :provider_duplicated if @user.has_provider?(@provider)
        return :provider_added if @user.add_provider(@provider, @auth_info.uid)
      elsif @user = User.find(:"#{@provider}_user" => @auth_info.uid)
    Severity: Minor
    Found in context/provider_auth.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method show_flash_message has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def show_flash_message
      markup = []

      if flash.has_key?(:info)
        markup << "<div class='alert alert-dismissable alert-info'>
    Severity: Minor
    Found in helpers/view_helper.rb - About 1 hr to fix

      Method call has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def call
      if @user
        return :provider_duplicated if @user.has_provider?(@provider)
        return :provider_added if @user.add_provider(@provider, @auth_info.uid)
      elsif @user = User.find(:"#{@provider}_user" => @auth_info.uid)
      Severity: Minor
      Found in context/provider_auth.rb - About 1 hr to fix

        Method parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.parse(log)
    output = ""
    members = []
    classes = {}
    log.split(/\n\r?/).each do |line|
        Severity: Minor
        Found in lib/parser/limechat_parser.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return :account_exists
        Severity: Major
        Found in context/provider_auth.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return :user_created
          Severity: Major
          Found in context/provider_auth.rb - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language