Sign upLogin

throrin19/svgutils

View on GitHub
Star
libs/matrix/utils.js

Summary

Maintainability
D
2 days
Test Coverage

Function transform2matrix has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    transform2matrix : function(tstr, bbox){
        var tdata = this.parseTransformString(tstr),
            m = new Matrix;
        if (tdata) {
            for (var i = 0, ii = tdata.length; i < ii; i++) {
Severity: Minor
Found in libs/matrix/utils.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function transform2matrix has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    transform2matrix : function(tstr, bbox){
        var tdata = this.parseTransformString(tstr),
            m = new Matrix;
        if (tdata) {
            for (var i = 0, ii = tdata.length; i < ii; i++) {
Severity: Major
Found in libs/matrix/utils.js - About 2 hrs to fix

    Function is has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        is : function(o, type) {
        type = Str.prototype.toLowerCase.call(type);
        if (type == "finite") {
            return isFinite(o);
        }
    Severity: Minor
    Found in libs/matrix/utils.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function bbox has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        bbox : function(x, y, width, height) {
        if (x == null) {
            x = y = width = height = 0;
        }
        if (y == null) {
    Severity: Minor
    Found in libs/matrix/utils.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                          if (tlen == 2) {
                        bb = bb || bbox;
                        m.rotate(t[1], bb.x + bb.width / 2, bb.y + bb.height / 2);
                    } else if (tlen == 4) {
                        if (absolute) {
      Severity: Major
      Found in libs/matrix/utils.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        } else if (command == "s") {
                    if (tlen == 2 || tlen == 3) {
                        bb = bb || bbox;
                        m.scale(t[1], t[tlen - 1], bb.x + bb.width / 2, bb.y + bb.height / 2);
                    } else if (tlen == 4) {
        Severity: Major
        Found in libs/matrix/utils.js - About 45 mins to fix

          Function rectPath has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              rectPath : function(x, y, w, h, r) {
          Severity: Minor
          Found in libs/matrix/utils.js - About 35 mins to fix

            Function clone has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                clone : function(obj) {
        if (typeof obj == "function" || Object(obj) !== obj) {
            return obj;
        }
        var res = new obj.constructor;
            Severity: Minor
            Found in libs/matrix/utils.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                } else if (tlen == 5) {
                        if (absolute) {
                            x2 = inver.x(t[3], t[4]);
                            y2 = inver.y(t[3], t[4]);
                            m.scale(t[1], t[2], x2, y2);
            Severity: Major
            Found in libs/matrix/utils.js and 1 other location - About 4 hrs to fix
            libs/matrix/utils.js on lines 101..117

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                } else if (tlen == 4) {
                        if (absolute) {
                            x2 = inver.x(t[2], t[3]);
                            y2 = inver.y(t[2], t[3]);
                            m.scale(t[1], t[1], x2, y2);
            Severity: Major
            Found in libs/matrix/utils.js and 1 other location - About 4 hrs to fix
            libs/matrix/utils.js on lines 109..117

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status