throrin19/svgutils

View on GitHub
libs/parser.js

Summary

Maintainability
C
1 day
Test Coverage

Function parseXmlNode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Parser.parseXmlNode = function parseXmlNode(node) {
    var nodes = [];

    _.each(node, function (content, index) {
        switch (index) {
Severity: Minor
Found in libs/parser.js - About 1 hr to fix

    Function parseJson has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    Parser.parseJson = function parseJson(elements) {
        var nodes = [];
    
        _.each(elements, function (element) {
            switch (element.type) {
    Severity: Minor
    Found in libs/parser.js - About 1 hr to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      Parser.parseXmlGroup = function parseXmlGroup(array) {
          var groups = [];
      
          _.each(array, function (item) {
              groups.push(elements.Group.fromNode(item));
      Severity: Major
      Found in libs/parser.js and 4 other locations - About 2 hrs to fix
      libs/parser.js on lines 168..176
      libs/parser.js on lines 192..200
      libs/parser.js on lines 216..224
      libs/parser.js on lines 240..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      Parser.parseXmlText = function parseXmlText(array) {
          var texts = [];
      
          _.each(array, function (item) {
              texts.push(elements.Text.fromNode(item));
      Severity: Major
      Found in libs/parser.js and 4 other locations - About 2 hrs to fix
      libs/parser.js on lines 119..127
      libs/parser.js on lines 168..176
      libs/parser.js on lines 216..224
      libs/parser.js on lines 240..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      Parser.parseXmlRect = function parseXmlRect(array) {
          var rects = [];
      
          _.each(array, function (item) {
              rects.push(elements.Rect.fromNode(item));
      Severity: Major
      Found in libs/parser.js and 4 other locations - About 2 hrs to fix
      libs/parser.js on lines 119..127
      libs/parser.js on lines 192..200
      libs/parser.js on lines 216..224
      libs/parser.js on lines 240..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      Parser.parseXmlImage = function parseXmlImage(array) {
          var images = [];
      
          _.each(array, function (item) {
              images.push(elements.Image.fromNode(item));
      Severity: Major
      Found in libs/parser.js and 4 other locations - About 2 hrs to fix
      libs/parser.js on lines 119..127
      libs/parser.js on lines 168..176
      libs/parser.js on lines 192..200
      libs/parser.js on lines 240..248

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      Parser.parseXmlCircle = function parseXmlCircle(array) {
          var circles = [];
      
          _.each(array, function (item) {
              circles.push(elements.Circle.fromNode(item));
      Severity: Major
      Found in libs/parser.js and 4 other locations - About 2 hrs to fix
      libs/parser.js on lines 119..127
      libs/parser.js on lines 168..176
      libs/parser.js on lines 192..200
      libs/parser.js on lines 216..224

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status