Sign upLogin

thunderer/SimilarWebApi

View on GitHub
Star

Showing 11 of 11 total issues

Function parseMaps has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseMaps(\SimpleXMLElement $xml)
        {
        $maps = array();
        if(array_key_exists('maps', $this->mapping))
            {
Severity: Minor
Found in src/Parser/XmlParser.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseTuples has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    private function parseTuples(\SimpleXMLElement $xml)
        {
        $tuples = array();
        if(array_key_exists('tuples', $this->mapping))
            {
Severity: Minor
Found in src/Parser/XmlParser.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validateArg has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function validateArg($arg, $value)
        {
        if('domain' == $arg && !$value)
            {
            throw new \InvalidArgumentException('Empty domain!');
Severity: Minor
Found in src/AbstractRequest.php - About 1 hr to fix

    Function validateArg has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function validateArg($arg, $value)
        {
        if('domain' == $arg && !$value)
            {
            throw new \InvalidArgumentException('Empty domain!');
    Severity: Minor
    Found in src/AbstractRequest.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method parseMaps has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function parseMaps(\SimpleXMLElement $xml)
        {
        $maps = array();
        if(array_key_exists('maps', $this->mapping))
            {
    Severity: Minor
    Found in src/Parser/XmlParser.php - About 1 hr to fix

      Function parseTuples has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function parseTuples(array $json)
        {
        $tuples = array();
        if(array_key_exists('tuples', $this->mapping))
            {
      Severity: Minor
      Found in src/Parser/JsonParser.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

              if('domain' == $arg && !$value)
            {
            throw new \InvalidArgumentException('Empty domain!');
            }
        elseif('app' == $arg && !$value)
      Severity: Major
      Found in src/AbstractRequest.php - About 1 hr to fix

        Function parseArrays has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function parseArrays(\SimpleXMLElement $xml)
        {
        $arrays = array();
        if(array_key_exists('arrays', $this->mapping))
            {
        Severity: Minor
        Found in src/Parser/XmlParser.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($raw, array $values, array $arrays, array $maps, array $tuples)
        Severity: Minor
        Found in src/RawResponse.php - About 35 mins to fix

          Function parseArrays has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function parseArrays(array $json)
        {
        $arrays = array();
        if(array_key_exists('arrays', $this->mapping))
            {
          Severity: Minor
          Found in src/Parser/JsonParser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parseMaps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function parseMaps(array $json)
        {
        $maps = array();
        if(array_key_exists('maps', $this->mapping))
            {
          Severity: Minor
          Found in src/Parser/JsonParser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language