Sign upLogin

tieme-ndo/backend

View on GitHub
Star
controllers/changeRequest/approveChangeRequest.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function approveChangeRequest has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const approveChangeRequest = async (req, res, next) => {
  try {
    const changeRequestEntry = await models.ChangeRequest.findOne({
      _id: req.params.id
    });
Severity: Major
Found in controllers/changeRequest/approveChangeRequest.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

        return next(
      createError({
        message: 'Internal database error',
        status: GENERIC_ERROR
      })
    Severity: Major
    Found in controllers/changeRequest/approveChangeRequest.js - About 30 mins to fix

      Function approveChangeRequest has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      const approveChangeRequest = async (req, res, next) => {
  try {
    const changeRequestEntry = await models.ChangeRequest.findOne({
      _id: req.params.id
    });
      Severity: Minor
      Found in controllers/changeRequest/approveChangeRequest.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Parsing error: Invalid ecmaVersion.
      Open

      const { models } = require('../../models');
      Severity: Minor
      Found in controllers/changeRequest/approveChangeRequest.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status