Sign upLogin

tjchambers/ancestry

View on GitHub
Star

Showing 4 of 4 total issues

Method has_ancestry has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def has_ancestry(options = {})
    # Check options
    raise Ancestry::AncestryException.new('Options for has_ancestry must be in a hash.') unless options.is_a? Hash
    options.each do |key, value|
      unless [:ancestry_column, :orphan_strategy, :cache_depth, :depth_cache_column].include? key
Severity: Minor
Found in lib/ancestry/has_ancestry.rb - About 1 hr to fix

    Method has_ancestry has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def has_ancestry(options = {})
    # Check options
    raise Ancestry::AncestryException.new('Options for has_ancestry must be in a hash.') unless options.is_a? Hash
    options.each do |key, value|
      unless [:ancestry_column, :orphan_strategy, :cache_depth, :depth_cache_column].include? key
    Severity: Minor
    Found in lib/ancestry/has_ancestry.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update_descendants_with_new_ancestry has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def update_descendants_with_new_ancestry
      # Skip this if callbacks are disabled
      unless ancestry_callbacks_disabled?
        # If node is not a new record and ancestry was updated and the new ancestry is sane ...
        if changed.include?(self.base_class.ancestry_column.to_s) && !new_record? && sane_ancestry?
    Severity: Minor
    Found in lib/ancestry/instance_methods.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method sort_by_ancestry has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def sort_by_ancestry(nodes)
      arranged = nodes.is_a?(Hash) ? nodes : arrange_nodes(nodes.sort_by{|n| n.ancestry || '0'})
      arranged.inject([]) do |sorted_nodes, pair|
        node, children = pair
        sorted_nodes << node
    Severity: Minor
    Found in lib/ancestry/class_methods.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language