Sign upLogin

tjcsl/ion

View on GitHub
Star

Showing 517 of 5,909 total issues

Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def authenticate(self, request, username=None, password=None):
        """Authenticate a username-password pair.

        Creates a new user if one is not already in the database.
Severity: Minor
Found in intranet/apps/auth/backends.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_enrichment_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def add_enrichment_view(request):
    """Add enrichment activity page."""

    is_enrichment_admin = request.user.has_admin_permission("enrichment")
Severity: Minor
Found in intranet/apps/enrichment/views.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function founditem_modify_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def founditem_modify_view(request, item_id=None):
    """
    Modify a FoundItem.

    Args:
Severity: Minor
Found in intranet/apps/lostfound/views.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function founditem_delete_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def founditem_delete_view(request, item_id):
    """
    Delete a FoundItem.

    Args:
Severity: Minor
Found in intranet/apps/lostfound/views.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _display_time has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _display_time(self, request, response):
        # display all stats since last reset
        stats_str = "%-4s %-24s %13s %14s %10s %12s %12s %12s %12s\n" % tuple(["Req", "Start time"] + time_labels)
        count = 0
        mins = defaultdict(int)
Severity: Minor
Found in intranet/middleware/profiler.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function modify_enrichment_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def modify_enrichment_view(request, enrichment_id):
    """Modify enrichment activity page.

    Args:
        enrichment_id (int): enrichment activity id
Severity: Minor
Found in intranet/apps/enrichment/views.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function oauth_toolkit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def oauth_toolkit(request):
    """
    Export application tokens arranged by application on OAuth pages.
    """
    if request.user.is_authenticated:
Severity: Minor
Found in intranet/apps/context_processors.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function lostitem_delete_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def lostitem_delete_view(request, item_id):
    """
    Delete a LostItem.

    Args:
Severity: Minor
Found in intranet/apps/lostfound/views.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function absence_count has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def absence_count(request):
    """Add the absence count to the context for students.

    Args:
        request: The request object
Severity: Minor
Found in intranet/apps/eighth/context_processors.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function eighth_admin_perform_group_signup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def eighth_admin_perform_group_signup(*, group_id: int, schact_virtual_id: int, schact_person_id: int, request: Optional[http.HttpRequest]):
    """Performs sign up of all users in a specific group up for a
    specific scheduled activity.

    Args:
Severity: Minor
Found in intranet/apps/eighth/views/admin/hybrid.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function metrics_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def metrics_view(request):
    remote_addr = request.META["HTTP_X_REAL_IP"] if "HTTP_X_REAL_IP" in request.META else request.META.get("REMOTE_ADDR", "")
    is_admin = request.user.is_authenticated and not request.user.is_restricted and request.user.has_admin_permission("eighth")

    # If they're not from an IP on the white list and they're not an eighth admin, deny access
Severity: Minor
Found in intranet/apps/eighth/views/monitoring.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function remove_member_from_group_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def remove_member_from_group_view(request, group_id, user_id):
    if request.method != "POST":
        return http.HttpResponseNotAllowed(["POST"], "HTTP 405: METHOD NOT ALLOWED")

    try:
Severity: Minor
Found in intranet/apps/eighth/views/admin/groups.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function migrate_outstanding_passes_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def migrate_outstanding_passes_view(request):
    if request.method == "POST":
        try:
            block_id = request.POST.get("block", None)
            block = EighthBlock.objects.get(id=block_id)
Severity: Minor
Found in intranet/apps/eighth/views/admin/attendance.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function clear_absence_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def clear_absence_view(request, signup_id):
    if request.method == "POST":
        try:
            signup = EighthSignup.objects.get(id=signup_id)
        except (EighthSignup.DoesNotExist, ValueError) as e:
Severity: Minor
Found in intranet/apps/eighth/views/admin/attendance.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function done has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def done(self, form_list, **kwargs):  # pylint: disable=unused-argument
        form_list = list(form_list)

        if hasattr(self, "no_activities"):
            response = redirect("eighth_attendance_choose_scheduled_activity")
Severity: Minor
Found in intranet/apps/eighth/views/attendance.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function edit_sponsor_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def edit_sponsor_view(request, sponsor_id):
    try:
        sponsor = EighthSponsor.objects.get(id=sponsor_id)
    except EighthSponsor.DoesNotExist as e:
        raise http.Http404 from e
Severity: Minor
Found in intranet/apps/eighth/views/admin/sponsors.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function leave_waitlist_view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def leave_waitlist_view(request):
    if not settings.ENABLE_WAITLIST:
        return http.HttpResponseForbidden("Waitlist functionality is currently disabled.")

    for field in ("uid", "bid"):
Severity: Minor
Found in intranet/apps/eighth/views/signup.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function done has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def done(self, form_list, **kwargs):
        form_list = list(form_list)
        block = form_list[0].cleaned_data["block"]
        activities = form_list[1].cleaned_data["activities"]
Severity: Minor
Found in intranet/apps/eighth/views/admin/groups.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_queryset has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def get_queryset(self):
        if "start_date" in self.request.GET:
            start_date = self.request.GET.get("start_date")
            if not self.is_valid_date(start_date):
                raise ValidationError("Invalid format for start_date.")
Severity: Minor
Found in intranet/apps/eighth/views/api.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def handle(self, *args, **options):
        log = not options["silent"]

        absences = EighthSignup.objects.get_absences().filter(absence_emailed=False)
Severity: Minor
Found in intranet/apps/eighth/management/commands/absence_email.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language