Sign upLogin

tmaiaroto/telepathic-black-panther

View on GitHub
Star
src/engagement.js

Summary

Maintainability
F
3 wks
Test Coverage

File engagement.js has 379 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * The engagement.js module includes functions that track events related to a visitor's behavior
 * and level of engagement. How are visitors engaging with a page? Are they reading the content? 
 * Commenting? Filling out forms? Or are they getting stuck on forms? Do they abandom them?
 * These kind of questions are answered by the events this module sends to GA.
Severity: Minor
Found in src/engagement.js - About 5 hrs to fix

Function inactivity has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    inactivity: function(opts) {
        opts = this.extend({
            "_method": "inactivity",
            "category": "behavior",
            "action": "inactive",
Severity: Minor
Found in src/engagement.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function timeToEngage has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

    timeToEngage: function(opts) {
        opts = this.extend({
            "_method": "timeToEngage",
            "category": "behavior",
            "action": "timeToEngage",
Severity: Minor
Found in src/engagement.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function linkOut has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    linkOut: function(opts) {
        opts = this.extend({
            "_method": "linkOut",
            "element": false,
            "elementEvent": false,
Severity: Major
Found in src/engagement.js - About 2 hrs to fix

Function leave has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    leave: function(opts) {
        opts = this.extend({
            "_method": "leave",
            "category": "behavior",
            "action": "",
Severity: Major
Found in src/engagement.js - About 2 hrs to fix

Function inactivity has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    inactivity: function(opts) {
        opts = this.extend({
            "_method": "inactivity",
            "category": "behavior",
            "action": "inactive",
Severity: Major
Found in src/engagement.js - About 2 hrs to fix

Function linkOut has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    linkOut: function(opts) {
        opts = this.extend({
            "_method": "linkOut",
            "element": false,
            "elementEvent": false,
Severity: Minor
Found in src/engagement.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function read has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    read: function(opts) {
        opts = this.extend({
            "_method": "read",
            "minTime": 10,
            "selector": "body",
Severity: Minor
Found in src/engagement.js - About 1 hr to fix

Function timeToEngage has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    timeToEngage: function(opts) {
        opts = this.extend({
            "_method": "timeToEngage",
            "category": "behavior",
            "action": "timeToEngage",
Severity: Minor
Found in src/engagement.js - About 1 hr to fix

Function scrolledPage has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    scrolledPage: function(opts) {
        opts = this.extend({
            "_method": "scrolledPage",
            "minTime": 2,
            "initialScrollRequired": true,
Severity: Minor
Found in src/engagement.js - About 1 hr to fix

Function inactivityCheck has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        var inactivityCheck = setInterval(function() {
            // Check to see if active is false, if so - there has been no activity.
            if(!active) {
                // Then check if enough time has passed for the periods defined in `opts.periods`
                for(var i in opts.periods) {
Severity: Minor
Found in src/engagement.js - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

                            if(opts.event === "click") {
                                opts.event = "focus";
                            }
Severity: Major
Found in src/engagement.js - About 45 mins to fix

Function leave has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    leave: function(opts) {
        opts = this.extend({
            "_method": "leave",
            "category": "behavior",
            "action": "",
Severity: Minor
Found in src/engagement.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

module.exports = {
    /**
     * Tracks a "read" event when users have spent enough time on a page and scrolled far enough.
     * 
     * @param  {Object} opts
Severity: Major
Found in src/engagement.js and 1 other location - About 3 wks to fix
dev/js/telepathic-black-panther.js on lines 950..1682

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 3580.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status