tollwerk/admin

View on GitHub

Showing 36 of 73 total issues

File DoctrineStorageAdapterStrategy.php has 567 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * admin
 *
Severity: Major
Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 1 day to fix

    File anonip.py has 361 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    #! /usr/bin/env python2
    
    """
    anonip.py 0.5:
    An ip address anonymizer
    Severity: Minor
    Found in app/anonip/anonip.py - About 4 hrs to fix

      DoctrineStorageAdapterStrategy has 28 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class DoctrineStorageAdapterStrategy implements StorageAdapterStrategyInterface
      {
          /**
           * Doctrine entity manager
           *
      Severity: Minor
      Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 3 hrs to fix

        Method __invoke has 80 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __invoke(VhostInterface $vhost)
            {
                $files = [];
        
                $variables = $this->config;
        Severity: Major
        Found in src/Admin/Infrastructure/Persistence/Apache.php - About 3 hrs to fix

          Function handle_ip_column has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

          def handle_ip_column(column, config):
              """
              This function extracts the ip from the column and returns the whole column
              with the ip anonymized.
              """
          Severity: Minor
          Found in app/anonip/anonip.py - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method testVhost has 67 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function testVhost()
              {
                  // Create an account
                  $this->assertTrue($this->getAdminCmd()->addArg('account:create')->addArg('test')->execute());
          
          
          Severity: Major
          Found in src/Admin/Tests/CliTest.php - About 2 hrs to fix

            Vhost has 23 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Vhost
            {
                /**
                 * Virtual host ID
                 *
            Severity: Minor
            Found in src/Admin/Infrastructure/Model/Vhost.php - About 2 hrs to fix

              Function read_stdin has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              def read_stdin(config):
                  """
                  This function reads from stdin and loops forever.
                  Output is either written to stdout or the file specified as argument.
                  The function does not return as it should loop forever.
              Severity: Minor
              Found in app/anonip/anonip.py - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function loadDomain has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function loadDomain($name, AccountInterface $account = null, $vhostDocroot = null)
                  {
                      $doctrineDomain = $this->domainRepository->findOneBy(['name' => $name]);
              
                      // If the domain is unknown

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method execute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function execute(InputInterface $input, OutputInterface $output)
                  {
                      $account = $input->getArgument('account');
                      $docroot = $input->getArgument('docroot');
                      $protocol = $input->getArgument('protocol');
              Severity: Minor
              Found in src/Admin/Infrastructure/Commands/Vhost/PortAddVhostCommand.php - About 1 hr to fix

                Method execute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    protected function execute(InputInterface $input, OutputInterface $output)
                    {
                        $account = $input->getArgument('account');
                        $docroot = $input->getArgument('docroot');
                        $protocol = $input->getArgument('protocol');
                Severity: Minor
                Found in src/Admin/Infrastructure/Commands/Vhost/PortRemoveVhostCommand.php - About 1 hr to fix

                  Method loadDomain has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function loadDomain($name, AccountInterface $account = null, $vhostDocroot = null)
                      {
                          $doctrineDomain = $this->domainRepository->findOneBy(['name' => $name]);
                  
                          // If the domain is unknown

                    Function verify_integer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def verify_integer(parser, arg, htzero):
                        """
                        Verifies if the supplied column and increment are valid.
                        """
                        try:
                    Severity: Minor
                    Found in app/anonip/anonip.py - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method createVhost has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function createVhost(AccountInterface $account, DomainInterface $domain, $docroot, $type)
                        {
                            $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);
                    
                            // If the account is unknown

                      Method addVhostDomain has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function addVhostDomain(AccountInterface $account, $docroot, DomainInterface $domain)
                          {
                              $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);
                      
                              // If the account is unknown

                        Method testDomain has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function testDomain()
                            {
                                // Create an account
                                $this->assertTrue($this->getAdminCmd()->addArg('account:create')->addArg('test')->execute());
                        
                        
                        Severity: Minor
                        Found in src/Admin/Tests/CliTest.php - About 1 hr to fix

                          Method removeVhostDomain has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function removeVhostDomain(AccountInterface $account, $docroot, DomainInterface $domain)
                              {
                                  $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);
                          
                                  // If the account is unknown

                            Method normalizeAbsolutePath has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function normalizeAbsolutePath($absolutePath)
                                {
                                    // If the path isn't absolute
                                    if (strncmp(DIRECTORY_SEPARATOR, $absolutePath, strlen(DIRECTORY_SEPARATOR))) {
                                        throw new \RuntimeException(sprintf('The path "%s" is not absolute', $absolutePath), 1479636650);
                            Severity: Minor
                            Found in src/Admin/Infrastructure/Service/DirectoryService.php - About 1 hr to fix

                              Method testAccount has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function testAccount()
                                  {
                                      // Create an account
                                      $this->assertTrue($this->getAdminCmd()->addArg('account:create')->addArg('test')->execute());
                                      $this->assertEquals(1, $this->getConnection()->getRowCount('account'));
                              Severity: Minor
                              Found in src/Admin/Tests/CliTest.php - About 1 hr to fix

                                Function phpVhost has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    public function phpVhost(AccountInterface $account, VhostInterface $vhost, $oldPhpVersion = null)
                                    {
                                        $accountHelper = new AccountHelper($account);
                                        $availableVhost = $accountHelper->vhostDirectory($vhost, false);
                                
                                
                                Severity: Minor
                                Found in src/Admin/Infrastructure/Service/PersistenceService.php - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language