Sign upLogin

tollwerk/admin

View on GitHub
Star

Showing 36 of 73 total issues

Function truncate_address has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def truncate_address(address, config):
    """Truncates the ip addresses"""
    # try ipv4 first....
    family = AF_INET
    addr_pton = pton_unpack4(address)
Severity: Minor
Found in app/anonip/anonip.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enableVhost has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function enableVhost(AccountInterface $account, VhostInterface $vhost)
    {
        // If both the account and the virtual host are active: Enable the virtual host
        if ($account->isActive() && $vhost->isActive()) {
            $accountHelper = new AccountHelper($account);
Severity: Minor
Found in src/Admin/Infrastructure/Service/PersistenceService.php - About 1 hr to fix

    Method execute has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function execute(InputInterface $input, OutputInterface $output)
    {
        $oldaccount = $input->getArgument('oldname');
        $newaccount = $input->getArgument('newname');
        try {
    Severity: Minor
    Found in src/Admin/Infrastructure/Commands/Account/RenameAccountCommand.php - About 1 hr to fix

      Function removeVhostPort has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function removeVhostPort(AccountInterface $account, $docroot, $protocol, $port)
    {
        $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);

        // If the account is unknown
      Severity: Minor
      Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function persist has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function persist(AccountInterface $account, VhostInterface $vhost)
    {
        $persister = new Apache($account, $this->config);
        $entries = $persister($vhost);
      Severity: Minor
      Found in src/Admin/Infrastructure/Strategy/ApachePersistenceAdapterStrategy.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __invoke has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __invoke(VhostInterface $vhost)
    {
        $files = [];

        $variables = $this->config;
      Severity: Minor
      Found in src/Admin/Infrastructure/Persistence/Apache.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function enableVhost has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function enableVhost(AccountInterface $account, VhostInterface $vhost)
    {
        // If both the account and the virtual host are active: Enable the virtual host
        if ($account->isActive() && $vhost->isActive()) {
            $accountHelper = new AccountHelper($account);
      Severity: Minor
      Found in src/Admin/Infrastructure/Service/PersistenceService.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addVhostPort has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function addVhostPort(AccountInterface $account, $docroot, $protocol, $port)
    {
        $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);

        // If the account is unknown
      Severity: Minor
      Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function loadFromDoctrineVhost has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function loadFromDoctrineVhost(DoctrineVhost $doctrineVhost)
    {
        $doctrinePrimaryDomain = $doctrineVhost->getPrimarydomain();
        $primaryDomain = $this->loadFromDoctrineDomain($doctrinePrimaryDomain);
      Severity: Minor
      Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function normalizeAbsolutePath has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function normalizeAbsolutePath($absolutePath)
    {
        // If the path isn't absolute
        if (strncmp(DIRECTORY_SEPARATOR, $absolutePath, strlen(DIRECTORY_SEPARATOR))) {
            throw new \RuntimeException(sprintf('The path "%s" is not absolute', $absolutePath), 1479636650);
      Severity: Minor
      Found in src/Admin/Infrastructure/Service/DirectoryService.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function deleteDirectory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function deleteDirectory($directory, $user, $group)
    {
        $files = array_diff(scandir($directory), array('.', '..'));
        foreach ($files as $file) {
            // Recursive call if it's a directory
      Severity: Minor
      Found in src/Admin/Infrastructure/Service/PersistenceService.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addVhostDomain has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function addVhostDomain(AccountInterface $account, $docroot, DomainInterface $domain)
    {
        $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);

        // If the account is unknown
      Severity: Minor
      Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return config.replace
      Severity: Major
      Found in app/anonip/anonip.py - About 30 mins to fix

        Function prepare has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function prepare(VhostInterface $vhost, AccountHelper $accountHelper)
    {
        // If the Certbot challenge directory is invalid
        $challengeDir = rtrim($this->config['challenge'], DIRECTORY_SEPARATOR);
        if (!is_dir($challengeDir)) {
        Severity: Minor
        Found in src/Admin/Infrastructure/Service/CertbotService.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function removeVhostDomain has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function removeVhostDomain(AccountInterface $account, $docroot, DomainInterface $domain)
    {
        $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);

        // If the account is unknown
        Severity: Minor
        Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createVhost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function createVhost(AccountInterface $account, DomainInterface $domain, $docroot, $type)
    {
        $doctrineAccount = $this->accountRepository->findOneBy(['name' => $account->getName()]);

        // If the account is unknown
        Severity: Minor
        Found in src/Admin/Infrastructure/Strategy/DoctrineStorageAdapterStrategy.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language