Sign upLogin

tolulope-od/banka

View on GitHub
Star
server/controllers/UserController.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function createStaff has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static async createStaff(req, res) {
    if (req.decoded.isAdmin) {
      const { firstName, lastName, email, admin } = req.body;
      const existingUser = await users.select(['email'], [`email='${email}'`]);
      if (existingUser.length > 0) {
Severity: Minor
Found in server/controllers/UserController.js - About 1 hr to fix

    Function adminAddStaff has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static async adminAddStaff(req, res) {
    if (req.decoded.isAdmin) {
      const { userEmail } = req.body;
      const findUser = await users.select(['*'], [`email='${userEmail}'`]);
    Severity: Minor
    Found in server/controllers/UserController.js - About 1 hr to fix

      Function fetchAllAccountsByUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static async fetchAllAccountsByUser(req, res) {
    const { userEmail } = req.params;
    let userAccounts;
    if (req.decoded.type !== 'staff') {
      if (req.decoded.email !== userEmail) {
      Severity: Minor
      Found in server/controllers/UserController.js - About 1 hr to fix

        Function adminAddStaff has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          static async adminAddStaff(req, res) {
    if (req.decoded.isAdmin) {
      const { userEmail } = req.body;
      const findUser = await users.select(['*'], [`email='${userEmail}'`]);
        Severity: Minor
        Found in server/controllers/UserController.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status