Sign upLogin

tom-weatherhead/othello-angular-electron

View on GitHub
Star

Showing 9 of 9 total issues

Function exports has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (config) => {
    config.set({
        basePath: '',
        frameworks: ['jasmine', '@angular-devkit/build-angular'],
        plugins: [
Severity: Major
Found in karma.conf.js - About 2 hrs to fix

    Function keyboardEventHandler has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function keyboardEventHandler(event: { preventDefault: () => void }, input: { code: string }) {
    // For example, only enable application menu keyboard shortcuts when Ctrl/Cmd are down:
    // win.webContents.setIgnoreMenuShortcuts(!input.control && !input.meta)

    if (!input || !input.code) {
    Severity: Minor
    Found in main.ts - About 1 hr to fix

      Function keyboardEventHandler has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function keyboardEventHandler(event: { preventDefault: () => void }, input: { code: string }) {
    // For example, only enable application menu keyboard shortcuts when Ctrl/Cmd are down:
    // win.webContents.setIgnoreMenuShortcuts(!input.control && !input.meta)

    if (!input || !input.code) {
      Severity: Minor
      Found in main.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function createWindow has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createWindow(launchInfo: unknown = undefined) {
    // launchInfo is defined only on macOS
    // console.log('launchInfo is', typeof launchInfo, launchInfo);

    // macOS: This icon appears briefly in the Menu Bar, not scaled.
      Severity: Minor
      Found in main.ts - About 1 hr to fix

        Function update_IsGameOver has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            update_IsGameOver(): boolean {
        if (this.gameState.isGameOver) {
            this.isGameOver = true;
        } else if (this.gameState.numPiecesFlippedInLastMove === 0) {
            if (this.lastMoveWasInvalid) {
        Severity: Minor
        Found in src/app/components/othello/othello.component.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function update_IsGameOver has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            update_IsGameOver(): boolean {
        if (this.gameState.isGameOver) {
            this.isGameOver = true;
        } else if (this.gameState.numPiecesFlippedInLastMove === 0) {
            if (this.lastMoveWasInvalid) {
        Severity: Minor
        Found in src/app/components/othello/othello.component.ts - About 1 hr to fix

          Function setDockMenu has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function setDockMenu() {
    if (!isPlatformMac) {
        return;
    }
          Severity: Minor
          Found in main.ts - About 1 hr to fix

            Function onAutomaticMove has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                onAutomaticMove(): void {
        // let player = this.gameState.player.token;
        // const c = `${this.gameState.player.colour}`;

        // player will be a string, either 'White' or 'Black'
            Severity: Minor
            Found in src/app/components/othello/othello.component.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function updateBoardFromGameState has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                updateBoardFromGameState(): void {
        if (!this.board) {
            // this.board = createAndFillArray(
            //     '',
            //     boardHeight,
            Severity: Minor
            Found in src/app/components/othello/othello.component.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language