tomasbasham/ember-cli-analytics

View on GitHub

Showing 3 of 11 total issues

Function insertTag has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  insertTag: on('init', function() {
    const config = get(this, 'config');
    const { id, remarketing, ecommerce, enhancedEcommerce, set } = assign({}, config);
    const properties = without(config, 'id', 'remarketing', 'ecommerce', 'enhancedEcommerce', 'set');

Severity: Minor
Found in addon/integrations/google-analytics.js - About 1 hr to fix

    Function insertTag has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      insertTag: on('init', function() {
        const config = get(this, 'config');
        const { id, remarketing, ecommerce, enhancedEcommerce, set } = assign({}, config);
        const properties = without(config, 'id', 'remarketing', 'ecommerce', 'enhancedEcommerce', 'set');
    
    
    Severity: Minor
    Found in addon/integrations/google-analytics.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

        if (canUseDOM && !window.uetq) {
          /* eslint-disable */
          (function(w,d,t,r,u){var f,n,i;w[u]=w[u]||[],f=function(){
            var o={ti:id};o.q=w[u],w[u]=new UET(o),w[u].push('pageLoad')},
            n=d.createElement(t),n.src=r,n.async=1,n.onload=n.onreadystatechange=function(){
    Severity: Major
    Found in addon/integrations/bing.js - About 40 mins to fix
      Severity
      Category
      Status
      Source
      Language