Sign upLogin

tomchentw/react-prop-types-element-of-type

View on GitHub
Star
src/__tests__/index.spec.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function describePropTypesElementOfType has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

describe(`propTypesElementOfType`, function describePropTypesElementOfType() {
  let domEl;
  let ChildComponent;
  let WrapperComponent;
  let consoleErrorSpy;
Severity: Major
Found in src/__tests__/index.spec.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it(`should not warn for valid element`, function it() {
    render(<WrapperComponent childElement={<ChildComponent />} />, domEl);

    expect(consoleErrorSpy.calls.length).toBe(0);
  });
    Severity: Major
    Found in src/__tests__/index.spec.js and 1 other location - About 1 hr to fix
    src/__tests__/index.spec.js on lines 62..66

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it(`should warn for invalid element`, function it() {
    render(<WrapperComponent childElement={<div />} />, domEl);

    expect(consoleErrorSpy.calls.length).toBe(1);
  });
    Severity: Major
    Found in src/__tests__/index.spec.js and 1 other location - About 1 hr to fix
    src/__tests__/index.spec.js on lines 74..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Use default import syntax to import 'expect'.
    Open

      default as expect,
    Severity: Minor
    Found in src/__tests__/index.spec.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Use default import syntax to import 'React'.
    Open

      default as React,
    Severity: Minor
    Found in src/__tests__/index.spec.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    JSX not allowed in files with extension '.js'
    Open

            return <div>Child</div>;
    Severity: Minor
    Found in src/__tests__/index.spec.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Use default import syntax to import 'ReactPropTypeLocations'.
    Open

      default as ReactPropTypeLocations,
    Severity: Minor
    Found in src/__tests__/index.spec.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Use default import syntax to import 'propTypesElementOfType'.
    Open

      default as propTypesElementOfType,
    Severity: Minor
    Found in src/__tests__/index.spec.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status