Sign upLogin

toptal/database_validations

View on GitHub
Star

Showing 4 of 42 total issues

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def initialize(columns, where_clause, index_name, available_indexes, table_name)
Severity: Minor
Found in lib/database_validations/lib/errors.rb - About 35 mins to fix

    Method validate_foreign_keys! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def validate_foreign_keys!(adapter = Adapters::BaseAdapter.new(validator.klass))
        validator.attributes.each do |attribute|
          reflection = validator.klass._reflect_on_association(attribute)

          next unless reflection
    Severity: Minor
    Found in lib/database_validations/lib/checkers/db_presence_validator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_indexes! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def validate_indexes!(klass) # rubocop:disable Metrics/AbcSize
        adapter = Adapters::BaseAdapter.new(klass)

        validator.attributes.map do |attribute|
          columns = KeyGenerator.unify_columns(attribute, validator.options[:scope])
    Severity: Minor
    Found in lib/database_validations/lib/checkers/db_uniqueness_validator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def validate(record)
      if record._database_validations_fallback
        super
      else
        attributes.each do |attribute|
    Severity: Minor
    Found in lib/database_validations/lib/validators/db_presence_validator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language