Sign upLogin

toshogakari/eLib

View on GitHub
Star

Showing 2 of 14 total issues

Method search has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

    def self.search(params, queries)
      if params.blank? or queries.blank?
        return self.all
      end
      arel = self.arel_table
Severity: Minor
Found in app/models/concerns/searchable.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const {book} = this.props;
    return (
      <div className="col-sm-6 col-md-4 col-lg-3">
        <div className="row article-item">
Severity: Minor
Found in app/assets/javascripts/components/components/Book.js - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language