Sign upLogin

trailofbits/http-security

View on GitHub
Star

Showing 3 of 7 total issues

File parser.rb has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'http/security/http_date'

require "parslet"
require 'uri'
Severity: Minor
Found in lib/http/security/parsers/parser.rb - About 3 hrs to fix

    Method to_s has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

            def to_s
          directives = []

          directives << "default-src #{@default_src}" if @default_src
          directives << "script-src #{@script_src}"   if @script_src
    Severity: Minor
    Found in lib/http/security/headers/content_security_policy.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method to_s has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def to_s
          if    @none            then 'none'
          elsif @master_only     then 'master-only'
          elsif @by_content_type then 'by-content-type'
          elsif @by_ftp_filename then 'by-ftp-filename'
    Severity: Minor
    Found in lib/http/security/headers/x_permitted_cross_domain_policies.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language