Sign upLogin

trailofbits/tubertc

View on GitHub
Star
public/js/login.js

Summary

Maintainability
D
2 days
Test Coverage

Function initialize has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    initialize: function(config) {
        var _this = this;
        if (typeof config.cameraBtn !== 'object' ||
            typeof config.micBtn !== 'object' ||
            typeof config.dashBtn !== 'object') {
Severity: Major
Found in public/js/login.js - About 5 hrs to fix

    File login.js has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @file This handles the following:
 *   + Parsing of the query string for a roomName (if it exists)
 *   + Checking localStorage to determine the following information:
 *     - Is a userName key set with a valid value? If so, autopopulate the username field with this
    Severity: Minor
    Found in public/js/login.js - About 3 hrs to fix

      Function _checkIfNonTlsAndChromeAbove47 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          _checkIfNonTlsAndChromeAbove47: function() {
        var userAgent = navigator.userAgent;
        if (window.location.protocol !== 'https:' &&
            (window.location.hostname !== 'localhost' && window.location.hostname !== '127.0.0.1')) {
            var browserString = null;
      Severity: Minor
      Found in public/js/login.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          initialize: function(config) {
        var _this = this;
        if (typeof config.cameraBtn !== 'object' ||
            typeof config.micBtn !== 'object' ||
            typeof config.dashBtn !== 'object') {
      Severity: Minor
      Found in public/js/login.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _checkIfNonTlsAndChromeAbove47 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _checkIfNonTlsAndChromeAbove47: function() {
        var userAgent = navigator.userAgent;
        if (window.location.protocol !== 'https:' &&
            (window.location.hostname !== 'localhost' && window.location.hostname !== '127.0.0.1')) {
            var browserString = null;
      Severity: Minor
      Found in public/js/login.js - About 1 hr to fix

        Function get has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            get: function() {
        var rawConfig = localStorage.tubertc;
        if (rawConfig !== undefined) {
            // TODO: are we certain we can trust JSON.parse to parse localStorage?
            try {
        Severity: Minor
        Found in public/js/login.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _browserCompatCheck has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            _browserCompatCheck: function() {
        var userAgent = navigator.userAgent;

        if (!('Notification' in window)) {
            ErrorMetric.log('_browserCompatCheck => browser does not support Notifications');
        Severity: Minor
        Found in public/js/login.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                    return 'full';
        Severity: Major
        Found in public/js/login.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return 'untested';
          Severity: Major
          Found in public/js/login.js - About 30 mins to fix

            FIXME found
            Open

                        // @todo FIXME: proofread and make this better
            Severity: Minor
            Found in public/js/login.js by fixme

            FIXME found
            Open

                        // @todo FIXME: proofread and make this better
            Severity: Minor
            Found in public/js/login.js by fixme

            FIXME found
            Open

                    // @todo FIXME: We only have tested Chrome, need to refactor this once more browsers are tested
            Severity: Minor
            Found in public/js/login.js by fixme

            FIXME found
            Open

                        // @todo FIXME: proofread and make this better
            Severity: Minor
            Found in public/js/login.js by fixme

            FIXME found
            Open

                            // @todo FIXME: maybe add a different sort of notification, like a tooltip?
            Severity: Minor
            Found in public/js/login.js by fixme

            FIXME found
            Open

                                // @todo FIXME: this case should not happen since we immediately call
            Severity: Minor
            Found in public/js/login.js by fixme

            TODO found
            Open

                        // TODO: are we certain we can trust JSON.parse to parse localStorage?
            Severity: Minor
            Found in public/js/login.js by fixme

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (userName.length === 0) {
            _loginAlert
                .html('Please provide a <b>user name</b>.')
                .stop(true, false)
                .slideDown();
            Severity: Major
            Found in public/js/login.js and 1 other location - About 1 hr to fix
            public/js/login.js on lines 330..337

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (roomName.length === 0) {
            _loginAlert
                .html('Please provide a <b>room name</b>.')
                .stop(true, false)
                .slideDown();
            Severity: Major
            Found in public/js/login.js and 1 other location - About 1 hr to fix
            public/js/login.js on lines 321..328

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status