trailofbits/tubertc

View on GitHub
public/js/vtc.js

Summary

Maintainability
C
1 day
Test Coverage

Function connect has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    connect: function(userName, roomName, successFn) {
        if (!this._validateConfig()) {
            ErrorMetric.log('VTCCore.connect => config changed somehow...');
            ErrorMetric.log('                => ' + JSON.stringify(this.config));

Severity: Major
Found in public/js/vtc.js - About 3 hrs to fix

    Function VTCClient has 68 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var VTCClient = function(myId, roomName, onErrorFn) {
        var _id = myId;
        var _room = roomName;
    
        /**
    Severity: Major
    Found in public/js/vtc.js - About 2 hrs to fix

      Function sendPeerMessage has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.sendPeerMessage = function(dest, msgType, msgData, successFn) {
              var target = {};
              if (typeof dest !== 'object' ||
                  (typeof dest.rtcId !== 'string' && typeof dest.room !== 'string')) {
                  ErrorMetric.log('VTCClient.sendPeerMessage => dest object is invalid');
      Severity: Minor
      Found in public/js/vtc.js - About 1 hr to fix

        Function VTCClient has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        var VTCClient = function(myId, roomName, onErrorFn) {
            var _id = myId;
            var _room = roomName;
        
            /**
        Severity: Minor
        Found in public/js/vtc.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        'peerId' was used before it was defined.
        Open

                        ErrorMetric.log("easyrtc.call => [error] failed to call " + peerId);
        Severity: Minor
        Found in public/js/vtc.js by eslint

        Disallow Early Use (no-use-before-define)

        In JavaScript, prior to ES6, variable and function declarations are hoisted to the top of a scope, so it's possible to use identifiers before their formal declarations in code. This can be confusing and some believe it is best to always declare variables and functions before using them.

        In ES6, block-level bindings (let and const) introduce a "temporal dead zone" where a ReferenceError will be thrown with any attempt to access the variable before its declaration.

        Rule Details

        This rule will warn when it encounters a reference to an identifier that has not yet been declared.

        Examples of incorrect code for this rule:

        /*eslint no-use-before-define: "error"*/
        /*eslint-env es6*/
        
        alert(a);
        var a = 10;
        
        f();
        function f() {}
        
        function g() {
            return b;
        }
        var b = 1;
        
        // With blockBindings: true
        {
            alert(c);
            let c = 1;
        }

        Examples of correct code for this rule:

        /*eslint no-use-before-define: "error"*/
        /*eslint-env es6*/
        
        var a;
        a = 10;
        alert(a);
        
        function f() {}
        f(1);
        
        var b = 1;
        function g() {
            return b;
        }
        
        // With blockBindings: true
        {
            let C;
            c++;
        }

        Options

        {
            "no-use-before-define": ["error", { "functions": true, "classes": true }]
        }
        • functions (boolean) - The flag which shows whether or not this rule checks function declarations. If this is true, this rule warns every reference to a function before the function declaration. Otherwise, ignores those references. Function declarations are hoisted, so it's safe. Default is true.
        • classes (boolean) - The flag which shows whether or not this rule checks class declarations of upper scopes. If this is true, this rule warns every reference to a class before the class declaration. Otherwise, ignores those references if the declaration is in upper function scopes. Class declarations are not hoisted, so it might be danger. Default is true.
        • variables (boolean) - This flag determines whether or not the rule checks variable declarations in upper scopes. If this is true, the rule warns every reference to a variable before the variable declaration. Otherwise, the rule ignores a reference if the declaration is in an upper scope, while still reporting the reference if it's in the same scope as the declaration. Default is true.

        This rule accepts "nofunc" string as an option. "nofunc" is the same as { "functions": false, "classes": true }.

        functions

        Examples of correct code for the { "functions": false } option:

        /*eslint no-use-before-define: ["error", { "functions": false }]*/
        
        f();
        function f() {}

        classes

        Examples of incorrect code for the { "classes": false } option:

        /*eslint no-use-before-define: ["error", { "classes": false }]*/
        /*eslint-env es6*/
        
        new A();
        class A {
        }

        Examples of correct code for the { "classes": false } option:

        /*eslint no-use-before-define: ["error", { "classes": false }]*/
        /*eslint-env es6*/
        
        function foo() {
            return new A();
        }
        
        class A {
        }

        variables

        Examples of incorrect code for the { "variables": false } option:

        /*eslint no-use-before-define: ["error", { "variables": false }]*/
        
        console.log(foo);
        var foo = 1;

        Examples of correct code for the { "variables": false } option:

        /*eslint no-use-before-define: ["error", { "variables": false }]*/
        
        function baz() {
            console.log(foo);
        }
        
        var foo = 1;

        Source: http://eslint.org/docs/rules/

        Strings must use singlequote.
        Open

                        ErrorMetric.log("easyrtc.call => " + errorCode + ': ' + errorText);
        Severity: Minor
        Found in public/js/vtc.js by eslint

        enforce the consistent use of either backticks, double, or single quotes (quotes)

        JavaScript allows you to define strings in one of three ways: double quotes, single quotes, and backticks (as of ECMAScript 6). For example:

        /*eslint-env es6*/
        
        var double = "double";
        var single = 'single';
        var backtick = `backtick`;    // ES6 only

        Each of these lines creates a string and, in some cases, can be used interchangeably. The choice of how to define strings in a codebase is a stylistic one outside of template literals (which allow embedded of expressions to be interpreted).

        Many codebases require strings to be defined in a consistent manner.

        Rule Details

        This rule enforces the consistent use of either backticks, double, or single quotes.

        Options

        This rule has two options, a string option and an object option.

        String option:

        • "double" (default) requires the use of double quotes wherever possible
        • "single" requires the use of single quotes wherever possible
        • "backtick" requires the use of backticks wherever possible

        Object option:

        • "avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise
        • "allowTemplateLiterals": true allows strings to use backticks

        Deprecated: The object property avoid-escape is deprecated; please use the object property avoidEscape instead.

        double

        Examples of incorrect code for this rule with the default "double" option:

        /*eslint quotes: ["error", "double"]*/
        
        var single = 'single';
        var unescaped = 'a string containing "double" quotes';

        Examples of correct code for this rule with the default "double" option:

        /*eslint quotes: ["error", "double"]*/
        /*eslint-env es6*/
        
        var double = "double";
        var backtick = `back\ntick`;  // backticks are allowed due to newline
        var backtick = tag`backtick`; // backticks are allowed due to tag

        single

        Examples of incorrect code for this rule with the "single" option:

        /*eslint quotes: ["error", "single"]*/
        
        var double = "double";
        var unescaped = "a string containing 'single' quotes";

        Examples of correct code for this rule with the "single" option:

        /*eslint quotes: ["error", "single"]*/
        /*eslint-env es6*/
        
        var single = 'single';
        var backtick = `back${x}tick`; // backticks are allowed due to substitution

        backticks

        Examples of incorrect code for this rule with the "backtick" option:

        /*eslint quotes: ["error", "backtick"]*/
        
        var single = 'single';
        var double = "double";
        var unescaped = 'a string containing `backticks`';

        Examples of correct code for this rule with the "backtick" option:

        /*eslint quotes: ["error", "backtick"]*/
        /*eslint-env es6*/
        
        var backtick = `backtick`;

        avoidEscape

        Examples of additional correct code for this rule with the "double", { "avoidEscape": true } options:

        /*eslint quotes: ["error", "double", { "avoidEscape": true }]*/
        
        var single = 'a string containing "double" quotes';

        Examples of additional correct code for this rule with the "single", { "avoidEscape": true } options:

        /*eslint quotes: ["error", "single", { "avoidEscape": true }]*/
        
        var double = "a string containing 'single' quotes";

        Examples of additional correct code for this rule with the "backtick", { "avoidEscape": true } options:

        /*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/
        
        var double = "a string containing `backtick` quotes"

        allowTemplateLiterals

        Examples of additional correct code for this rule with the "double", { "allowTemplateLiterals": true } options:

        /*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/
        
        var double = "double";
        var double = `double`;

        Examples of additional correct code for this rule with the "single", { "allowTemplateLiterals": true } options:

        /*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/
        
        var single = 'single';
        var single = `single`;

        When Not To Use It

        If you do not need consistency in your string styles, you can safely disable this rule. Source: http://eslint.org/docs/rules/

        Missing semicolon.
        Open

                                })
        Severity: Minor
        Found in public/js/vtc.js by eslint

        require or disallow semicolons instead of ASI (semi)

        JavaScript is unique amongst the C-like languages in that it doesn't require semicolons at the end of each statement. In many cases, the JavaScript engine can determine that a semicolon should be in a certain spot and will automatically add it. This feature is known as automatic semicolon insertion (ASI) and is considered one of the more controversial features of JavaScript. For example, the following lines are both valid:

        var name = "ESLint"
        var website = "eslint.org";

        On the first line, the JavaScript engine will automatically insert a semicolon, so this is not considered a syntax error. The JavaScript engine still knows how to interpret the line and knows that the line end indicates the end of the statement.

        In the debate over ASI, there are generally two schools of thought. The first is that we should treat ASI as if it didn't exist and always include semicolons manually. The rationale is that it's easier to always include semicolons than to try to remember when they are or are not required, and thus decreases the possibility of introducing an error.

        However, the ASI mechanism can sometimes be tricky to people who are using semicolons. For example, consider this code:

        return
        {
            name: "ESLint"
        };

        This may look like a return statement that returns an object literal, however, the JavaScript engine will interpret this code as:

        return;
        {
            name: "ESLint";
        }

        Effectively, a semicolon is inserted after the return statement, causing the code below it (a labeled literal inside a block) to be unreachable. This rule and the [no-unreachable](no-unreachable.md) rule will protect your code from such cases.

        On the other side of the argument are those who says that since semicolons are inserted automatically, they are optional and do not need to be inserted manually. However, the ASI mechanism can also be tricky to people who don't use semicolons. For example, consider this code:

        var globalCounter = { }
        
        (function () {
            var n = 0
            globalCounter.increment = function () {
                return ++n
            }
        })()

        In this example, a semicolon will not be inserted after the first line, causing a run-time error (because an empty object is called as if it's a function). The [no-unexpected-multiline](no-unexpected-multiline.md) rule can protect your code from such cases.

        Although ASI allows for more freedom over your coding style, it can also make your code behave in an unexpected way, whether you use semicolons or not. Therefore, it is best to know when ASI takes place and when it does not, and have ESLint protect your code from these potentially unexpected cases. In short, as once described by Isaac Schlueter, a \n character always ends a statement (just like a semicolon) unless one of the following is true:

        1. The statement has an unclosed paren, array literal, or object literal or ends in some other way that is not a valid way to end a statement. (For instance, ending with . or ,.)
        2. The line is -- or ++ (in which case it will decrement/increment the next token.)
        3. It is a for(), while(), do, if(), or else, and there is no {
        4. The next line starts with [, (, +, *, /, -, ,, ., or some other binary operator that can only be found between two tokens in a single expression.

        Rule Details

        This rule enforces consistent use of semicolons.

        Options

        This rule has two options, a string option and an object option.

        String option:

        • "always" (default) requires semicolons at the end of statements
        • "never" disallows semicolons as the end of statements (except to disambiguate statements beginning with [, (, /, +, or -)

        Object option:

        • "omitLastInOneLineBlock": true ignores the last semicolon in a block in which its braces (and therefore the content of the block) are in the same line

        always

        Examples of incorrect code for this rule with the default "always" option:

        /*eslint semi: ["error", "always"]*/
        
        var name = "ESLint"
        
        object.method = function() {
            // ...
        }

        Examples of correct code for this rule with the default "always" option:

        /*eslint semi: "error"*/
        
        var name = "ESLint";
        
        object.method = function() {
            // ...
        };

        never

        Examples of incorrect code for this rule with the "never" option:

        /*eslint semi: ["error", "never"]*/
        
        var name = "ESLint";
        
        object.method = function() {
            // ...
        };

        Examples of correct code for this rule with the "never" option:

        /*eslint semi: ["error", "never"]*/
        
        var name = "ESLint"
        
        object.method = function() {
            // ...
        }
        
        var name = "ESLint"
        
        ;(function() {
            // ...
        })()

        omitLastInOneLineBlock

        Examples of additional correct code for this rule with the "always", { "omitLastInOneLineBlock": true } options:

        /*eslint semi: ["error", "always", { "omitLastInOneLineBlock": true}] */
        
        if (foo) { bar() }
        
        if (foo) { bar(); baz() }

        When Not To Use It

        If you do not want to enforce semicolon usage (or omission) in any particular way, then you can turn this rule off.

        Further Reading

        Related Rules

        • [no-extra-semi](no-extra-semi.md)
        • [no-unexpected-multiline](no-unexpected-multiline.md)
        • [semi-spacing](semi-spacing.md) Source: http://eslint.org/docs/rules/

        Strings must use singlequote.
        Open

                        ErrorMetric.log("easyrtc.call => [error] failed to call " + peerId);
        Severity: Minor
        Found in public/js/vtc.js by eslint

        enforce the consistent use of either backticks, double, or single quotes (quotes)

        JavaScript allows you to define strings in one of three ways: double quotes, single quotes, and backticks (as of ECMAScript 6). For example:

        /*eslint-env es6*/
        
        var double = "double";
        var single = 'single';
        var backtick = `backtick`;    // ES6 only

        Each of these lines creates a string and, in some cases, can be used interchangeably. The choice of how to define strings in a codebase is a stylistic one outside of template literals (which allow embedded of expressions to be interpreted).

        Many codebases require strings to be defined in a consistent manner.

        Rule Details

        This rule enforces the consistent use of either backticks, double, or single quotes.

        Options

        This rule has two options, a string option and an object option.

        String option:

        • "double" (default) requires the use of double quotes wherever possible
        • "single" requires the use of single quotes wherever possible
        • "backtick" requires the use of backticks wherever possible

        Object option:

        • "avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise
        • "allowTemplateLiterals": true allows strings to use backticks

        Deprecated: The object property avoid-escape is deprecated; please use the object property avoidEscape instead.

        double

        Examples of incorrect code for this rule with the default "double" option:

        /*eslint quotes: ["error", "double"]*/
        
        var single = 'single';
        var unescaped = 'a string containing "double" quotes';

        Examples of correct code for this rule with the default "double" option:

        /*eslint quotes: ["error", "double"]*/
        /*eslint-env es6*/
        
        var double = "double";
        var backtick = `back\ntick`;  // backticks are allowed due to newline
        var backtick = tag`backtick`; // backticks are allowed due to tag

        single

        Examples of incorrect code for this rule with the "single" option:

        /*eslint quotes: ["error", "single"]*/
        
        var double = "double";
        var unescaped = "a string containing 'single' quotes";

        Examples of correct code for this rule with the "single" option:

        /*eslint quotes: ["error", "single"]*/
        /*eslint-env es6*/
        
        var single = 'single';
        var backtick = `back${x}tick`; // backticks are allowed due to substitution

        backticks

        Examples of incorrect code for this rule with the "backtick" option:

        /*eslint quotes: ["error", "backtick"]*/
        
        var single = 'single';
        var double = "double";
        var unescaped = 'a string containing `backticks`';

        Examples of correct code for this rule with the "backtick" option:

        /*eslint quotes: ["error", "backtick"]*/
        /*eslint-env es6*/
        
        var backtick = `backtick`;

        avoidEscape

        Examples of additional correct code for this rule with the "double", { "avoidEscape": true } options:

        /*eslint quotes: ["error", "double", { "avoidEscape": true }]*/
        
        var single = 'a string containing "double" quotes';

        Examples of additional correct code for this rule with the "single", { "avoidEscape": true } options:

        /*eslint quotes: ["error", "single", { "avoidEscape": true }]*/
        
        var double = "a string containing 'single' quotes";

        Examples of additional correct code for this rule with the "backtick", { "avoidEscape": true } options:

        /*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/
        
        var double = "a string containing `backtick` quotes"

        allowTemplateLiterals

        Examples of additional correct code for this rule with the "double", { "allowTemplateLiterals": true } options:

        /*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/
        
        var double = "double";
        var double = `double`;

        Examples of additional correct code for this rule with the "single", { "allowTemplateLiterals": true } options:

        /*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/
        
        var single = 'single';
        var single = `single`;

        When Not To Use It

        If you do not need consistency in your string styles, you can safely disable this rule. Source: http://eslint.org/docs/rules/

        'VTCCore' is assigned a value but never used.
        Open

        var VTCCore = {
        Severity: Minor
        Found in public/js/vtc.js by eslint

        Disallow Unused Variables (no-unused-vars)

        Variables that are declared and not used anywhere in the code are most likely an error due to incomplete refactoring. Such variables take up space in the code and can lead to confusion by readers.

        Rule Details

        This rule is aimed at eliminating unused variables, functions, and parameters of functions.

        A variable is considered to be used if any of the following are true:

        • It represents a function that is called (doSomething())
        • It is read (var y = x)
        • It is passed into a function as an argument (doSomething(x))
        • It is read inside of a function that is passed to another function (doSomething(function() { foo(); }))

        A variable is not considered to be used if it is only ever assigned to (var x = 5) or declared.

        Examples of incorrect code for this rule:

        /*eslint no-unused-vars: "error"*/
        /*global some_unused_var*/
        
        // It checks variables you have defined as global
        some_unused_var = 42;
        
        var x;
        
        // Write-only variables are not considered as used.
        var y = 10;
        y = 5;
        
        // A read for a modification of itself is not considered as used.
        var z = 0;
        z = z + 1;
        
        // By default, unused arguments cause warnings.
        (function(foo) {
            return 5;
        })();
        
        // Unused recursive functions also cause warnings.
        function fact(n) {
            if (n < 2) return 1;
            return n * fact(n - 1);
        }
        
        // When a function definition destructures an array, unused entries from the array also cause warnings.
        function getY([x, y]) {
            return y;
        }

        Examples of correct code for this rule:

        /*eslint no-unused-vars: "error"*/
        
        var x = 10;
        alert(x);
        
        // foo is considered used here
        myFunc(function foo() {
            // ...
        }.bind(this));
        
        (function(foo) {
            return foo;
        })();
        
        var myFunc;
        myFunc = setTimeout(function() {
            // myFunc is considered used
            myFunc();
        }, 50);
        
        // Only the second argument from the descructured array is used.
        function getY([, y]) {
            return y;
        }

        exported

        In environments outside of CommonJS or ECMAScript modules, you may use var to create a global variable that may be used by other scripts. You can use the /* exported variableName */ comment block to indicate that this variable is being exported and therefore should not be considered unused.

        Note that /* exported */ has no effect for any of the following:

        • when the environment is node or commonjs
        • when parserOptions.sourceType is module
        • when ecmaFeatures.globalReturn is true

        The line comment // exported variableName will not work as exported is not line-specific.

        Examples of correct code for /* exported variableName */ operation:

        /* exported global_var */
        
        var global_var = 42;

        Options

        This rule takes one argument which can be a string or an object. The string settings are the same as those of the vars property (explained below).

        By default this rule is enabled with all option for variables and after-used for arguments.

        {
            "rules": {
                "no-unused-vars": ["error", { "vars": "all", "args": "after-used", "ignoreRestSiblings": false }]
            }
        }

        vars

        The vars option has two settings:

        • all checks all variables for usage, including those in the global scope. This is the default setting.
        • local checks only that locally-declared variables are used but will allow global variables to be unused.

        vars: local

        Examples of correct code for the { "vars": "local" } option:

        /*eslint no-unused-vars: ["error", { "vars": "local" }]*/
        /*global some_unused_var */
        
        some_unused_var = 42;

        varsIgnorePattern

        The varsIgnorePattern option specifies exceptions not to check for usage: variables whose names match a regexp pattern. For example, variables whose names contain ignored or Ignored.

        Examples of correct code for the { "varsIgnorePattern": "[iI]gnored" } option:

        /*eslint no-unused-vars: ["error", { "varsIgnorePattern": "[iI]gnored" }]*/
        
        var firstVarIgnored = 1;
        var secondVar = 2;
        console.log(secondVar);

        args

        The args option has three settings:

        • after-used - only the last argument must be used. This allows you, for instance, to have two named parameters to a function and as long as you use the second argument, ESLint will not warn you about the first. This is the default setting.
        • all - all named arguments must be used.
        • none - do not check arguments.

        args: after-used

        Examples of incorrect code for the default { "args": "after-used" } option:

        /*eslint no-unused-vars: ["error", { "args": "after-used" }]*/
        
        // 1 error
        // "baz" is defined but never used
        (function(foo, bar, baz) {
            return bar;
        })();

        Examples of correct code for the default { "args": "after-used" } option:

        /*eslint no-unused-vars: ["error", {"args": "after-used"}]*/
        
        (function(foo, bar, baz) {
            return baz;
        })();

        args: all

        Examples of incorrect code for the { "args": "all" } option:

        /*eslint no-unused-vars: ["error", { "args": "all" }]*/
        
        // 2 errors
        // "foo" is defined but never used
        // "baz" is defined but never used
        (function(foo, bar, baz) {
            return bar;
        })();

        args: none

        Examples of correct code for the { "args": "none" } option:

        /*eslint no-unused-vars: ["error", { "args": "none" }]*/
        
        (function(foo, bar, baz) {
            return bar;
        })();

        ignoreRestSiblings

        The ignoreRestSiblings option is a boolean (default: false). Using a Rest Property it is possible to "omit" properties from an object, but by default the sibling properties are marked as "unused". With this option enabled the rest property's siblings are ignored.

        Examples of correct code for the { "ignoreRestSiblings": true } option:

        /*eslint no-unused-vars: ["error", { "ignoreRestSiblings": true }]*/
        // 'type' is ignored because it has a rest property sibling.
        var { type, ...coords } = data;

        argsIgnorePattern

        The argsIgnorePattern option specifies exceptions not to check for usage: arguments whose names match a regexp pattern. For example, variables whose names begin with an underscore.

        Examples of correct code for the { "argsIgnorePattern": "^_" } option:

        /*eslint no-unused-vars: ["error", { "argsIgnorePattern": "^_" }]*/
        
        function foo(x, _y) {
            return x + 1;
        }
        foo();

        caughtErrors

        The caughtErrors option is used for catch block arguments validation.

        It has two settings:

        • none - do not check error objects. This is the default setting.
        • all - all named arguments must be used.

        caughtErrors: none

        Not specifying this rule is equivalent of assigning it to none.

        Examples of correct code for the { "caughtErrors": "none" } option:

        /*eslint no-unused-vars: ["error", { "caughtErrors": "none" }]*/
        
        try {
            //...
        } catch (err) {
            console.error("errors");
        }

        caughtErrors: all

        Examples of incorrect code for the { "caughtErrors": "all" } option:

        /*eslint no-unused-vars: ["error", { "caughtErrors": "all" }]*/
        
        // 1 error
        // "err" is defined but never used
        try {
            //...
        } catch (err) {
            console.error("errors");
        }

        caughtErrorsIgnorePattern

        The caughtErrorsIgnorePattern option specifies exceptions not to check for usage: catch arguments whose names match a regexp pattern. For example, variables whose names begin with a string 'ignore'.

        Examples of correct code for the { "caughtErrorsIgnorePattern": "^ignore" } option:

        /*eslint no-unused-vars: ["error", { "caughtErrorsIgnorePattern": "^ignore" }]*/
        
        try {
            //...
        } catch (ignoreErr) {
            console.error("errors");
        }

        When Not To Use It

        If you don't want to be notified about unused variables or function arguments, you can safely turn this rule off. Source: http://eslint.org/docs/rules/

        'roomName' is defined but never used.
        Open

                        }, function(errorCode, errorText, roomName) {
        Severity: Minor
        Found in public/js/vtc.js by eslint

        Disallow Unused Variables (no-unused-vars)

        Variables that are declared and not used anywhere in the code are most likely an error due to incomplete refactoring. Such variables take up space in the code and can lead to confusion by readers.

        Rule Details

        This rule is aimed at eliminating unused variables, functions, and parameters of functions.

        A variable is considered to be used if any of the following are true:

        • It represents a function that is called (doSomething())
        • It is read (var y = x)
        • It is passed into a function as an argument (doSomething(x))
        • It is read inside of a function that is passed to another function (doSomething(function() { foo(); }))

        A variable is not considered to be used if it is only ever assigned to (var x = 5) or declared.

        Examples of incorrect code for this rule:

        /*eslint no-unused-vars: "error"*/
        /*global some_unused_var*/
        
        // It checks variables you have defined as global
        some_unused_var = 42;
        
        var x;
        
        // Write-only variables are not considered as used.
        var y = 10;
        y = 5;
        
        // A read for a modification of itself is not considered as used.
        var z = 0;
        z = z + 1;
        
        // By default, unused arguments cause warnings.
        (function(foo) {
            return 5;
        })();
        
        // Unused recursive functions also cause warnings.
        function fact(n) {
            if (n < 2) return 1;
            return n * fact(n - 1);
        }
        
        // When a function definition destructures an array, unused entries from the array also cause warnings.
        function getY([x, y]) {
            return y;
        }

        Examples of correct code for this rule:

        /*eslint no-unused-vars: "error"*/
        
        var x = 10;
        alert(x);
        
        // foo is considered used here
        myFunc(function foo() {
            // ...
        }.bind(this));
        
        (function(foo) {
            return foo;
        })();
        
        var myFunc;
        myFunc = setTimeout(function() {
            // myFunc is considered used
            myFunc();
        }, 50);
        
        // Only the second argument from the descructured array is used.
        function getY([, y]) {
            return y;
        }

        exported

        In environments outside of CommonJS or ECMAScript modules, you may use var to create a global variable that may be used by other scripts. You can use the /* exported variableName */ comment block to indicate that this variable is being exported and therefore should not be considered unused.

        Note that /* exported */ has no effect for any of the following:

        • when the environment is node or commonjs
        • when parserOptions.sourceType is module
        • when ecmaFeatures.globalReturn is true

        The line comment // exported variableName will not work as exported is not line-specific.

        Examples of correct code for /* exported variableName */ operation:

        /* exported global_var */
        
        var global_var = 42;

        Options

        This rule takes one argument which can be a string or an object. The string settings are the same as those of the vars property (explained below).

        By default this rule is enabled with all option for variables and after-used for arguments.

        {
            "rules": {
                "no-unused-vars": ["error", { "vars": "all", "args": "after-used", "ignoreRestSiblings": false }]
            }
        }

        vars

        The vars option has two settings:

        • all checks all variables for usage, including those in the global scope. This is the default setting.
        • local checks only that locally-declared variables are used but will allow global variables to be unused.

        vars: local

        Examples of correct code for the { "vars": "local" } option:

        /*eslint no-unused-vars: ["error", { "vars": "local" }]*/
        /*global some_unused_var */
        
        some_unused_var = 42;

        varsIgnorePattern

        The varsIgnorePattern option specifies exceptions not to check for usage: variables whose names match a regexp pattern. For example, variables whose names contain ignored or Ignored.

        Examples of correct code for the { "varsIgnorePattern": "[iI]gnored" } option:

        /*eslint no-unused-vars: ["error", { "varsIgnorePattern": "[iI]gnored" }]*/
        
        var firstVarIgnored = 1;
        var secondVar = 2;
        console.log(secondVar);

        args

        The args option has three settings:

        • after-used - only the last argument must be used. This allows you, for instance, to have two named parameters to a function and as long as you use the second argument, ESLint will not warn you about the first. This is the default setting.
        • all - all named arguments must be used.
        • none - do not check arguments.

        args: after-used

        Examples of incorrect code for the default { "args": "after-used" } option:

        /*eslint no-unused-vars: ["error", { "args": "after-used" }]*/
        
        // 1 error
        // "baz" is defined but never used
        (function(foo, bar, baz) {
            return bar;
        })();

        Examples of correct code for the default { "args": "after-used" } option:

        /*eslint no-unused-vars: ["error", {"args": "after-used"}]*/
        
        (function(foo, bar, baz) {
            return baz;
        })();

        args: all

        Examples of incorrect code for the { "args": "all" } option:

        /*eslint no-unused-vars: ["error", { "args": "all" }]*/
        
        // 2 errors
        // "foo" is defined but never used
        // "baz" is defined but never used
        (function(foo, bar, baz) {
            return bar;
        })();

        args: none

        Examples of correct code for the { "args": "none" } option:

        /*eslint no-unused-vars: ["error", { "args": "none" }]*/
        
        (function(foo, bar, baz) {
            return bar;
        })();

        ignoreRestSiblings

        The ignoreRestSiblings option is a boolean (default: false). Using a Rest Property it is possible to "omit" properties from an object, but by default the sibling properties are marked as "unused". With this option enabled the rest property's siblings are ignored.

        Examples of correct code for the { "ignoreRestSiblings": true } option:

        /*eslint no-unused-vars: ["error", { "ignoreRestSiblings": true }]*/
        // 'type' is ignored because it has a rest property sibling.
        var { type, ...coords } = data;

        argsIgnorePattern

        The argsIgnorePattern option specifies exceptions not to check for usage: arguments whose names match a regexp pattern. For example, variables whose names begin with an underscore.

        Examples of correct code for the { "argsIgnorePattern": "^_" } option:

        /*eslint no-unused-vars: ["error", { "argsIgnorePattern": "^_" }]*/
        
        function foo(x, _y) {
            return x + 1;
        }
        foo();

        caughtErrors

        The caughtErrors option is used for catch block arguments validation.

        It has two settings:

        • none - do not check error objects. This is the default setting.
        • all - all named arguments must be used.

        caughtErrors: none

        Not specifying this rule is equivalent of assigning it to none.

        Examples of correct code for the { "caughtErrors": "none" } option:

        /*eslint no-unused-vars: ["error", { "caughtErrors": "none" }]*/
        
        try {
            //...
        } catch (err) {
            console.error("errors");
        }

        caughtErrors: all

        Examples of incorrect code for the { "caughtErrors": "all" } option:

        /*eslint no-unused-vars: ["error", { "caughtErrors": "all" }]*/
        
        // 1 error
        // "err" is defined but never used
        try {
            //...
        } catch (err) {
            console.error("errors");
        }

        caughtErrorsIgnorePattern

        The caughtErrorsIgnorePattern option specifies exceptions not to check for usage: catch arguments whose names match a regexp pattern. For example, variables whose names begin with a string 'ignore'.

        Examples of correct code for the { "caughtErrorsIgnorePattern": "^ignore" } option:

        /*eslint no-unused-vars: ["error", { "caughtErrorsIgnorePattern": "^ignore" }]*/
        
        try {
            //...
        } catch (ignoreErr) {
            console.error("errors");
        }

        When Not To Use It

        If you don't want to be notified about unused variables or function arguments, you can safely turn this rule off. Source: http://eslint.org/docs/rules/

        FIXME found
        Open

                    // @todo FIXME: proofread and make this text better
        Severity: Minor
        Found in public/js/vtc.js by fixme

        FIXME found
        Open

                        // @todo FIXME: proofread and make this text better
        Severity: Minor
        Found in public/js/vtc.js by fixme

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if (_this._errorFn !== undefined) {
                                _this._errorFn({
                                    title: 'Failed to join room',
                                    content: 'We are unable to join the video teleconference room.<br><br>' +
                                             '<b>Error Code</b>: ' + errorCode + '<br>' +
        Severity: Minor
        Found in public/js/vtc.js and 1 other location - About 35 mins to fix
        public/js/vtc.js on lines 467..474

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (_this._errorFn !== undefined) {
                            _this._errorFn({
                                title: 'An Error Has Occurred',
                                content: 'We are unable to join the video teleconferencing session.<br><br>' +
                                          '<b>Error Code</b>: ' + errorCode + '<br>' +
        Severity: Minor
        Found in public/js/vtc.js and 1 other location - About 35 mins to fix
        public/js/vtc.js on lines 453..460

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status