treble37/rsocialize

View on GitHub

Showing 4 of 4 total issues

Method recursive_js_build has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def recursive_js_build(options, key, button_val) 
    @retval=%Q{#{key.to_s}: }
    @retval = @retval+"{" if hash_depth(options[key])>0
    if options[key].is_a?(Hash)
      options[key].each_key do |nested_key|
Severity: Minor
Found in lib/rsocialize.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sharrre has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def sharrre
  $_GET = Hash.new
  #$_GET['url'] = 'http://sharrre.com/'  ##In PHP, the predefined $_GET variable is used to collect values in a form with method="get".
  $_GET['url'] = params[:url]
  $_GET['type'] = params[:type]
Severity: Minor
Found in lib/generators/rsocialize/templates/rsocialize_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sharrre has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def sharrre
  $_GET = Hash.new
  #$_GET['url'] = 'http://sharrre.com/'  ##In PHP, the predefined $_GET variable is used to collect values in a form with method="get".
  $_GET['url'] = params[:url]
  $_GET['type'] = params[:type]
Severity: Minor
Found in lib/generators/rsocialize/templates/rsocialize_controller.rb - About 1 hr to fix

    Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def parse(encUrl)
      #curb method docs for curl::Easy: http://curb.rubyforge.org/classes/Curl/Easy.html#M000038
        @options = Hash.new
        
      #curl_setopt() constants in php: http://www.php.net/manual/en/function.curl-setopt.php for translation in ruby below
    Severity: Minor
    Found in lib/generators/rsocialize/templates/rsocialize_controller.rb - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language