treyhunner/ember-deploy-ssh-index

View on GitHub

Showing 6 of 15 total issues

File unit.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* jshint node: true */
'use strict';
require('blanket')();

var assert = require('assert');
Severity: Minor
Found in node_tests/unit.js - About 2 hrs to fix

    Function createDeployPlugin has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      createDeployPlugin: function(options) {
        var SSHAdapter = require('./lib/ssh-adapter');
    
        var DeployPlugin = DeployPluginBase.extend({
          name: options.name,
    Severity: Major
    Found in index.js - About 2 hrs to fix

      Function _activateRevision has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _activateRevision: function (targetRevision, revisions) {
          var keyPrefix = this._plugin.readConfig('keyPrefix');
      
          var revisionKeys = revisions.map(function(element) {
            return element.revision;
      Severity: Major
      Found in lib/ssh-adapter.js - About 2 hrs to fix

        Function _uploadIfMissing has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _uploadIfMissing: function(value, revisionKey) {
            var keyPrefix = this._plugin.readConfig('keyPrefix');
            var key = (keyPrefix ? keyPrefix + ':' : '') + revisionKey;
        
            var conn = this._client;
        Severity: Minor
        Found in lib/ssh-adapter.js - About 1 hr to fix

          Function _getFileList has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _getFileList: function() {
              var conn = this._client;
              var remoteDir = this._plugin.readConfig('remoteDir');
              var connectionOptions = this._getConnectionOptions.bind(this)();
          
          
          Severity: Minor
          Found in lib/ssh-adapter.js - About 1 hr to fix

            Function createDeployPlugin has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              createDeployPlugin: function(options) {
                var SSHAdapter = require('./lib/ssh-adapter');
            
                var DeployPlugin = DeployPluginBase.extend({
                  name: options.name,
            Severity: Minor
            Found in index.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language