Sign upLogin

treyhunner/ember-deploy-ssh-index

View on GitHub
Star
lib/ssh-adapter.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function _activateRevision has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _activateRevision: function (targetRevision, revisions) {
    var keyPrefix = this._plugin.readConfig('keyPrefix');

    var revisionKeys = revisions.map(function(element) {
      return element.revision;
Severity: Major
Found in lib/ssh-adapter.js - About 2 hrs to fix

    Function _uploadIfMissing has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _uploadIfMissing: function(value, revisionKey) {
    var keyPrefix = this._plugin.readConfig('keyPrefix');
    var key = (keyPrefix ? keyPrefix + ':' : '') + revisionKey;

    var conn = this._client;
    Severity: Minor
    Found in lib/ssh-adapter.js - About 1 hr to fix

      Function _getFileList has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _getFileList: function() {
    var conn = this._client;
    var remoteDir = this._plugin.readConfig('remoteDir');
    var connectionOptions = this._getConnectionOptions.bind(this)();
      Severity: Minor
      Found in lib/ssh-adapter.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return this._getFileList()
    .then(this._excludeCurrentRevisionFile.bind(this))
    .then(this._getRevisions.bind(this))
    .then(this._activateRevision.bind(this, revision))
        Severity: Minor
        Found in lib/ssh-adapter.js and 1 other location - About 55 mins to fix
        lib/ssh-adapter.js on lines 37..40

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return this._getFileList()
    .then(this._sortFileList.bind(this))
    .then(this._excludeCurrentRevisionFile.bind(this))
    .then(this._getRevisions.bind(this));
        Severity: Minor
        Found in lib/ssh-adapter.js and 1 other location - About 55 mins to fix
        lib/ssh-adapter.js on lines 17..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status