Sign upLogin

trileg/WebTeX

View on GitHub
Star
WebTeX/static/js/preference.js

Summary

Maintainability
F
4 days
Test Coverage

Function configureLdap has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function configureLdap() {
  if ((!$("#ldap-address").val() || !$("#ldap-port").val()) || !$("#ldap-basedn").val()) {
    $("#result-change-ldap").empty();
    $("#result-change-ldap").append(
        '<p class="result bg-danger">Please input LDAP Address, Port, BaseDN correctly</p>'
Severity: Minor
Found in WebTeX/static/js/preference.js - About 1 hr to fix

    Function changePath has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function changePath() {
  if (!$("#redpen-path").val() || !$("#java-home").val()) {
    $("#result-change-path").empty();
    $("#result-change-path").append(
        '<p class="result bg-danger">Please input RedPen Path and/or JAVA_HOME</p>'
    Severity: Minor
    Found in WebTeX/static/js/preference.js - About 1 hr to fix

      Function register has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function register() {
  if (!$("#username").val() || !$("#password").val()) {
    $("#result-user-registration").empty();
    $("#result-user-registration").append(
        '<p class="result bg-danger">Please input username and/or password</p>'
      Severity: Minor
      Found in WebTeX/static/js/preference.js - About 1 hr to fix

        Function readConfig has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function readConfig() {
  var json = JSON.stringify({
    "_csrf_token": $("#_csrf_token").val()
  });
        Severity: Minor
        Found in WebTeX/static/js/preference.js - About 1 hr to fix

          Function readConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function readConfig() {
  var json = JSON.stringify({
    "_csrf_token": $("#_csrf_token").val()
  });
          Severity: Minor
          Found in WebTeX/static/js/preference.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function changePath() {
  if (!$("#redpen-path").val() || !$("#java-home").val()) {
    $("#result-change-path").empty();
    $("#result-change-path").append(
        '<p class="result bg-danger">Please input RedPen Path and/or JAVA_HOME</p>'
          Severity: Major
          Found in WebTeX/static/js/preference.js and 1 other location - About 1 day to fix
          WebTeX/static/js/preference.js on lines 66..103

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 302.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          function register() {
  if (!$("#username").val() || !$("#password").val()) {
    $("#result-user-registration").empty();
    $("#result-user-registration").append(
        '<p class="result bg-danger">Please input username and/or password</p>'
          Severity: Major
          Found in WebTeX/static/js/preference.js and 1 other location - About 1 day to fix
          WebTeX/static/js/preference.js on lines 145..182

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 302.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status