trufflesuite/truffle

View on GitHub
packages/contract/lib/execute.js

Summary

Maintainability
D
2 days
Test Coverage

File execute.js has 385 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const debug = require("debug")("contract:execute");
const PromiEvent = require("./promievent");
const EventEmitter = require("events");
const utils = require("./utils");
const StatusError = require("./statuserror");
Severity: Minor
Found in packages/contract/lib/execute.js - About 5 hrs to fix

    Function deploy has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      deploy: function (constructorABI) {
        const constructor = this;
        const web3 = constructor.web3;
    
        return function () {
    Severity: Major
    Found in packages/contract/lib/execute.js - About 2 hrs to fix

      Function send has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        send: function (fn, methodABI, address) {
          const constructor = this;
          const web3 = constructor.web3;
      
          return function () {
      Severity: Minor
      Found in packages/contract/lib/execute.js - About 1 hr to fix

        Function event has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          event: function (fn) {
            const constructor = this;
            const decode = utils.decodeLogs;
            let currentLogID = null;
        
        
        Severity: Minor
        Found in packages/contract/lib/execute.js - About 1 hr to fix

          Function call has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            call: function (fn, methodABI, address) {
              const constructor = this;
          
              return function () {
                let defaultBlock = constructor.web3.eth.defaultBlock || "latest";
          Severity: Minor
          Found in packages/contract/lib/execute.js - About 1 hr to fix

            Function getGasEstimate has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              getGasEstimate: function (params, blockLimit, stacktrace = false) {
                const constructor = this;
                const interfaceAdapter = constructor.interfaceAdapter;
                const web3 = constructor.web3;
            
            
            Severity: Minor
            Found in packages/contract/lib/execute.js - About 1 hr to fix

              Function allEvents has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                allEvents: function (web3Instance) {
                  const constructor = this;
                  const decode = utils.decodeLogs;
                  let currentLogID = null;
              
              
              Severity: Minor
              Found in packages/contract/lib/execute.js - About 1 hr to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        event.on(
                          "data",
                          e =>
                            dedupe(e.id) &&
                            emitter.emit("data", decode.call(constructor, e, true)[0])
                Severity: Major
                Found in packages/contract/lib/execute.js and 3 other locations - About 50 mins to fix
                packages/contract/lib/execute.js on lines 383..388
                packages/contract/lib/execute.js on lines 416..421
                packages/contract/lib/execute.js on lines 422..427

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        event.on(
                          "data",
                          e =>
                            dedupe(e.id) &&
                            emitter.emit("data", decode.call(constructor, e, true)[0])
                Severity: Major
                Found in packages/contract/lib/execute.js and 3 other locations - About 50 mins to fix
                packages/contract/lib/execute.js on lines 377..382
                packages/contract/lib/execute.js on lines 383..388
                packages/contract/lib/execute.js on lines 422..427

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        event.on(
                          "changed",
                          e =>
                            dedupe(e.id) &&
                            emitter.emit("changed", decode.call(constructor, e, true)[0])
                Severity: Major
                Found in packages/contract/lib/execute.js and 3 other locations - About 50 mins to fix
                packages/contract/lib/execute.js on lines 377..382
                packages/contract/lib/execute.js on lines 416..421
                packages/contract/lib/execute.js on lines 422..427

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                        event.on(
                          "changed",
                          e =>
                            dedupe(e.id) &&
                            emitter.emit("changed", decode.call(constructor, e, true)[0])
                Severity: Major
                Found in packages/contract/lib/execute.js and 3 other locations - About 50 mins to fix
                packages/contract/lib/execute.js on lines 377..382
                packages/contract/lib/execute.js on lines 383..388
                packages/contract/lib/execute.js on lines 416..421

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status