Sign upLogin

trufflesuite/truffle

View on GitHub
Star
packages/debugger/lib/controller/sagas/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function continueUntilBreakpoint has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function* continueUntilBreakpoint(action) {
  //if breakpoints was not specified, use the stored list from the state.
  //if it was, override that with the specified list.
  //note that explicitly specifying an empty list will advance to the end.
  let breakpoints =
Severity: Major
Found in packages/debugger/lib/controller/sagas/index.js - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (start !== undefined && length !== undefined) {
          //node-based (well, source-range-based) breakpoint
          return (
            sourceId === currentSourceId &&
            start === currentStart &&
    Severity: Critical
    Found in packages/debugger/lib/controller/sagas/index.js - About 2 hrs to fix

      Function stepOver has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function* stepOver() {
  const startingDepth = yield select(controller.current.functionDepth);
  const startingLocation = yield select(controller.current.location);
  const startingNode = yield select(controller.current.location.node);
  let currentDepth;
      Severity: Minor
      Found in packages/debugger/lib/controller/sagas/index.js - About 1 hr to fix

        Function stepNext has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        function* stepNext() {
  const starting = yield select(controller.current.location);
  const isStartingGenerated = yield select(
    controller.current.isAnyFrameGenerated
  );
        Severity: Minor
        Found in packages/debugger/lib/controller/sagas/index.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function continueUntilBreakpoint has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function* continueUntilBreakpoint(action) {
  //if breakpoints was not specified, use the stored list from the state.
  //if it was, override that with the specified list.
  //note that explicitly specifying an empty list will advance to the end.
  let breakpoints =
        Severity: Minor
        Found in packages/debugger/lib/controller/sagas/index.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function stepOver has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function* stepOver() {
  const startingDepth = yield select(controller.current.functionDepth);
  const startingLocation = yield select(controller.current.location);
  const startingNode = yield select(controller.current.location.node);
  let currentDepth;
        Severity: Minor
        Found in packages/debugger/lib/controller/sagas/index.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              (upcoming.sourceRange.start === starting.sourceRange.start &&
        upcoming.sourceRange.length === starting.sourceRange.length &&
        upcoming.source.id === starting.source.id))
        Severity: Minor
        Found in packages/debugger/lib/controller/sagas/index.js and 1 other location - About 35 mins to fix
        packages/debugger/lib/stacktrace/selectors/index.js on lines 401..403

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status