Sign upLogin

trufflesuite/truffle

View on GitHub
Star
packages/debugger/lib/evm/reducers.js

Summary

Maintainability
D
2 days
Test Coverage

Function codex has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function codex(state = DEFAULT_CODEX, action) {
  let newState, topCodex, topCodexNoZero;

  const updateFrameStorage = (frame, address, slot, value) => ({
    ...frame,
Severity: Major
Found in packages/debugger/lib/evm/reducers.js - About 5 hrs to fix

    File reducers.js has 342 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import debugModule from "debug";
const debug = debugModule("debugger:evm:reducers");

import { combineReducers } from "redux";
    Severity: Minor
    Found in packages/debugger/lib/evm/reducers.js - About 4 hrs to fix

      Function codex has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function codex(state = DEFAULT_CODEX, action) {
  let newState, topCodex, topCodexNoZero;

  const updateFrameStorage = (frame, address, slot, value) => ({
    ...frame,
      Severity: Minor
      Found in packages/debugger/lib/evm/reducers.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return state.map(frame =>
          updateFrameStorage(frame, address, slot, value)
        );
      Severity: Major
      Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return state.map(frame =>
        updateFrameCode(frame, address, binary, context)
      );
        Severity: Major
        Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return safePop(state);
          Severity: Major
          Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return state;
            Severity: Major
            Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return safeSave(state);
              Severity: Major
              Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return [state[0]]; //leave the -1 frame on the stack
                Severity: Major
                Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return safeSave(newState);
                  Severity: Major
                  Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return DEFAULT_CODEX;
                    Severity: Major
                    Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return state;
                      Severity: Major
                      Found in packages/debugger/lib/evm/reducers.js - About 30 mins to fix

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                        function blockHash(state = null, action) {
  switch (action.type) {
    case actions.SAVE_TX_IDENTIFICATION:
      return action.blockHash;
    case actions.UNLOAD_TRANSACTION:
                        Severity: Major
                        Found in packages/debugger/lib/evm/reducers.js and 2 other locations - About 55 mins to fix
                        packages/debugger/lib/evm/reducers.js on lines 101..110
                        packages/debugger/lib/evm/reducers.js on lines 117..126

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                        function txIndex(state = null, action) {
  switch (action.type) {
    case actions.SAVE_TX_IDENTIFICATION:
      return action.txIndex;
    case actions.UNLOAD_TRANSACTION:
                        Severity: Major
                        Found in packages/debugger/lib/evm/reducers.js and 2 other locations - About 55 mins to fix
                        packages/debugger/lib/evm/reducers.js on lines 90..99
                        packages/debugger/lib/evm/reducers.js on lines 117..126

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                        function status(state = null, action) {
  switch (action.type) {
    case actions.SAVE_STATUS:
      return action.status;
    case actions.UNLOAD_TRANSACTION:
                        Severity: Major
                        Found in packages/debugger/lib/evm/reducers.js and 2 other locations - About 55 mins to fix
                        packages/debugger/lib/evm/reducers.js on lines 90..99
                        packages/debugger/lib/evm/reducers.js on lines 101..110

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status