Sign upLogin

trufflesuite/truffle

View on GitHub
Star
packages/debugger/lib/txlog/actions/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function instantExternalCall has 12 arguments (exceeds 4 allowed). Consider refactoring.
Open

  pointer,
  newPointer, //does not actually affect the current pointer!
  step,
  address,
  context,
Severity: Major
Found in packages/debugger/lib/txlog/actions/index.js - About 1 hr to fix

    Function externalCall has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      pointer,
  newPointer,
  step,
  address,
  context,
    Severity: Major
    Found in packages/debugger/lib/txlog/actions/index.js - About 1 hr to fix

      Function instantCreate has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        pointer,
  newPointer, //does not actually affect the current pointer!
  step,
  address,
  context,
      Severity: Major
      Found in packages/debugger/lib/txlog/actions/index.js - About 1 hr to fix

        Function create has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          pointer,
  newPointer,
  step,
  address,
  context,
        Severity: Major
        Found in packages/debugger/lib/txlog/actions/index.js - About 1 hr to fix

          Function store has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          export function store(pointer, newPointer, step, rawSlot, rawValue) {
          Severity: Minor
          Found in packages/debugger/lib/txlog/actions/index.js - About 35 mins to fix

            Function externalReturn has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              pointer,
  newPointer,
  step,
  decodings,
  returnData
            Severity: Minor
            Found in packages/debugger/lib/txlog/actions/index.js - About 35 mins to fix

              Function logEvent has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              export function logEvent(pointer, newPointer, step, decoding, rawEventInfo) {
              Severity: Minor
              Found in packages/debugger/lib/txlog/actions/index.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  return {
    type: EXTERNAL_CALL,
    pointer,
    newPointer,
    step,
                Severity: Major
                Found in packages/debugger/lib/txlog/actions/index.js and 1 other location - About 1 hr to fix
                packages/debugger/lib/web3/sagas/index.js on lines 166..179

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 64.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 5 locations. Consider refactoring.
                Open

                export function externalReturn(
  pointer,
  newPointer,
  step,
  decodings,
                Severity: Major
                Found in packages/debugger/lib/txlog/actions/index.js and 4 other locations - About 45 mins to fix
                packages/debugger/lib/data/actions/index.js on lines 2..11
                packages/debugger/lib/data/actions/index.js on lines 33..48
                packages/debugger/lib/evm/actions/index.js on lines 74..83
                packages/debugger/lib/stacktrace/actions/index.js on lines 2..17

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export function store(pointer, newPointer, step, rawSlot, rawValue) {
  return {
    type: STORE,
    pointer,
    newPointer, //does not actually affect current pointer!
                Severity: Minor
                Found in packages/debugger/lib/txlog/actions/index.js and 1 other location - About 45 mins to fix
                packages/debugger/lib/txlog/actions/index.js on lines 203..212

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                export function logEvent(pointer, newPointer, step, decoding, rawEventInfo) {
  return {
    type: LOG_EVENT,
    pointer,
    newPointer, //does not actually affect current pointer!
                Severity: Minor
                Found in packages/debugger/lib/txlog/actions/index.js and 1 other location - About 45 mins to fix
                packages/debugger/lib/txlog/actions/index.js on lines 216..225

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status