tsurupin/portfolio

View on GitHub
frontend/src/shared/reducers/items.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function default has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function (state = [], action) {
  switch (action.type) {
    case FETCH_ITEMS:
      return action.payload.items;

Severity: Major
Found in frontend/src/shared/reducers/items.js - About 2 hrs to fix

    Function default has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function (state = [], action) {
      switch (action.type) {
        case FETCH_ITEMS:
          return action.payload.items;
    
    
    Severity: Minor
    Found in frontend/src/shared/reducers/items.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return [
              ...state.slice(0, action.payload.sortRank),
              ...succItem,
              ...subject,
              ...state.slice(action.payload.sortRank + 2),
    Severity: Major
    Found in frontend/src/shared/reducers/items.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return state;
      Severity: Major
      Found in frontend/src/shared/reducers/items.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return state;
        Severity: Major
        Found in frontend/src/shared/reducers/items.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return [
                    ...state.slice(0, action.payload.sortRank),
                    ...state.slice(action.payload.sortRank + 1),
                    ...bottomItem,
                  ];
          Severity: Major
          Found in frontend/src/shared/reducers/items.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status