tue-robotics/robot-api

View on GitHub

Showing 8 of 20 total issues

Function _updateEntities has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

  _updateEntities(entities) {
    const add = [];
    const update = [];
    const remove = [];

Severity: Minor
Found in lib/ed.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _updateEntities has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _updateEntities(entities) {
    const add = [];
    const update = [];
    const remove = [];

Severity: Major
Found in lib/ed.js - About 2 hrs to fix

    Function constructor has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      constructor(modules = {}) {
        // parent constructor
        // EventEmitter2.apply(this);
        super();
    
    
    Severity: Minor
    Found in lib/robot.js - About 1 hr to fix

      Function getActions has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function getActions(name, part) {
        const props = properties[name];
        if (!props) {
          return null;
        }
      Severity: Minor
      Found in lib/hardware.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function constructor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        constructor(robot) {
          const {ros} = robot;
      
          // Define the action
          this.action = new ActionClient({
      Severity: Minor
      Found in lib/body.js - About 1 hr to fix

        Function getActions has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getActions(name, part) {
          const props = properties[name];
          if (!props) {
            return null;
          }
        Severity: Minor
        Found in lib/hardware.js - About 1 hr to fix

          Function update_snapshots has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          EdSnapshots.prototype.update_snapshots = function(callback, max_num_revisions) {
            callback = callback || _.noop;
            max_num_revisions = max_num_revisions || 0;
          
            var request = {
          Severity: Minor
          Found in lib/graveyard/ed-snapshots.js - About 1 hr to fix

            Function constructor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              constructor(modules = {}) {
                // parent constructor
                // EventEmitter2.apply(this);
                super();
            
            
            Severity: Minor
            Found in lib/robot.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language