Sign upLogin

tylermercier/shift_planning

View on GitHub
Star

Showing 2 of 2 total issues

Method message_for_status has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def message_for_status(status)
      case status
      when -3 then "Flagged API Key - Pemanently Banned"
      when -2 then "Flagged API Key - Too Many invalid access attempts - contact us"
      when -1 then "Flagged API Key - Temporarily Disabled - contact us"
Severity: Minor
Found in lib/shift_planning/api_error.rb - About 1 hr to fix

    Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(config = {})
      raise ArgumentError.new('Missing username') unless config.key?(:username)
      @username = config[:username]

      raise ArgumentError.new('Missing password') unless config.key?(:password)
    Severity: Minor
    Found in lib/shift_planning/client.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language