uPortal-Project/uportal-home

File services.js has 418 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * Licensed to Apereo under one or more contributor license
 * agreements. See the NOTICE file distributed with this work
 * for additional information regarding copyright ownership.
 * Apereo licenses this file to you under the Apache License,

Function getLayout has 72 lines of code (exceeds 25 allowed). Consider refactoring.

Open

          var getLayout = function() {
            $log.log('getLayout (new backend version)');
            return checkLayoutCache().then(function(data) {
              var successFn;
              var errorFn;

Function formatLayoutForCache has 42 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        var formatLayoutForCache = function(data) {
          var result = {
            'layout': [],
          };
          //  Check if there are duplicate fnames in data.layout

Function persistAndUse has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

              var persistAndUse = function(result) {
                $log.log('persistAndUse: got data from old layout backend: ' +
                  result.data.layout);
                var formattedOldLayout = formatLayoutForCache(result.data);

Function getExclusiveMarkup has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        var getExclusiveMarkup = function(portlet) {
          return $http.get(SERVICE_LOC.context +
              '/p/' + portlet.fname + '/exclusive/render.uP', {cache: true})
              .then(function(result) {
                  var data = result.data;

Function moveStuff has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

                index, length, sourceId, previousNodeId, nextNodeId) {

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            var folders = data.layout.folders.filter(function(el) {
              var result = false;
              if (el && SERVICE_LOC.layoutTab === el.title) {
                result = true;
              }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            var tabs = data.layout.navigation.tabs.filter(function(el) {
              var result = false;
              if (el && SERVICE_LOC.layoutTab === el.name) {
                result = true;
              }

• Read up
  Read up