Sign upLogin

uPortal-Project/uportal-home

View on GitHub
Star
web/src/main/webapp/my-app/layout/static/controllers.js

Summary

Maintainability
F
4 days
Test Coverage

Function addToHome has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        vm.addToHome = function(portlet) {
          console.log("addToHome: pportlet", portlet);
          var ret = layoutService.addToHome(portlet);
          console.log("addToHome: ret", ret);
          ret.success(function(request, text) {
Severity: Minor
Found in web/src/main/webapp/my-app/layout/static/controllers.js - About 1 hr to fix

    Function addToHome has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            vm.addToHome = function(portlet) {
          var ret = layoutService.addToHome(portlet);
          ret.success(function(request, text) {
            angular.element('.fname-' + portlet.fname)
              .html('<span style="color : green;">' +
    Severity: Minor
    Found in web/src/main/webapp/my-app/layout/static/controllers.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                ret.success(function(request, text) {
            angular.element('.fname-' + portlet.fname)
              .html('<span style="color : green;">' +
                '<i class="fa fa-check"></i> Added Successfully</span>')
              .prop('disabled', true);
      Severity: Major
      Found in web/src/main/webapp/my-app/layout/static/controllers.js and 1 other location - About 1 day to fix
      web/src/main/webapp/my-app/layout/static/controllers.js on lines 117..147

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 241.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                ret.success(function(request, text) {
            angular.element('.fname-' + portlet.fname)
              .html('<span style="color : green;">' +
                '<i class="fa fa-check"></i> Added Successfully</span>')
              .prop('disabled', true);
      Severity: Major
      Found in web/src/main/webapp/my-app/layout/static/controllers.js and 1 other location - About 1 day to fix
      web/src/main/webapp/my-app/layout/static/controllers.js on lines 156..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 241.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (angular.isUndefined($scope.portlet) ||
          angular.isUndefined($scope.portlet.fname)) {
          if (result.status === 403) {
            $scope.loaded = true;
            $scope.empty = false;
      Severity: Major
      Found in web/src/main/webapp/my-app/layout/static/controllers.js and 1 other location - About 4 hrs to fix
      web/src/main/webapp/my-app/layout/static/controllers.js on lines 94..108

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (angular.isUndefined($scope.portlet) ||
          angular.isUndefined($scope.portlet.fname)) {
          if (result.status === 403) {
            $scope.loaded = true;
            $scope.empty = false;
      Severity: Major
      Found in web/src/main/webapp/my-app/layout/static/controllers.js and 1 other location - About 4 hrs to fix
      web/src/main/webapp/my-app/layout/static/controllers.js on lines 43..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 117.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            layoutService.getGuestMode().then(function(guest) {
        $scope.guestMode = guest;
        return guest;
      }).catch(function() {
        $log.warn('could not retrieve guest mode');
      Severity: Major
      Found in web/src/main/webapp/my-app/layout/static/controllers.js and 1 other location - About 1 hr to fix
      web/src/main/webapp/my-app/layout/controllers.js on lines 541..547

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status