Sign upLogin

uPortal-Project/uportal-home

View on GitHub
Star
web/src/main/webapp/my-app/search/controllers.js

Summary

Maintainability
C
1 day
Test Coverage

Function init has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      var init = function() {
        initwiscDirectoryResultLimit();
        $scope.myuwResults = [];
        $scope.filteredApps = [];
        $scope.appDirectoryLoading = true;
Severity: Minor
Found in web/src/main/webapp/my-app/search/controllers.js - About 1 hr to fix

    Function initDirectorySearch has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          var initDirectorySearch = function() {
        $scope.wiscDirectoryLoading = true;
        $scope.wiscDirectoryResultsBadge = '?';
        $scope.wiscDirectoryHopeForResults = true;
        directorySearchService.directorySearch($scope.searchTerm).then(
    Severity: Minor
    Found in web/src/main/webapp/my-app/search/controllers.js - About 1 hr to fix

      Function filterAppsBySearchTerm has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            var filterAppsBySearchTerm = function(apps) {
        // Filter by title matches first
        var appsWithMatchingTitle =
          marketplaceService.filterPortletsBySearchTerm(
            apps,
      Severity: Minor
      Found in web/src/main/webapp/my-app/search/controllers.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              googleCustomSearchService.googleSearchEnabled()
      .then(function(googleSearchEnabled) {
        $scope.googleSearchEnabled = googleSearchEnabled;
        if (googleSearchEnabled) {
          initWiscEduSearch();
        Severity: Major
        Found in web/src/main/webapp/my-app/search/controllers.js and 1 other location - About 2 hrs to fix
        web/src/main/webapp/my-app/search/controllers.js on lines 274..283

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              directorySearchService.directorySearchEnabled()
      .then(function(directoryEnabled) {
        $scope.directoryEnabled = directoryEnabled;
        if (directoryEnabled) {
          initDirectorySearch();
        Severity: Major
        Found in web/src/main/webapp/my-app/search/controllers.js and 1 other location - About 2 hrs to fix
        web/src/main/webapp/my-app/search/controllers.js on lines 264..273

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                mainService.isGuest()
          .then(function(isGuest) {
            if (isGuest) {
              $scope.showAll = true;
            }
        Severity: Major
        Found in web/src/main/webapp/my-app/search/controllers.js and 1 other location - About 1 hr to fix
        web/src/main/webapp/my-app/marketplace/controllers.js on lines 276..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $scope.onSelect = function(portlet) {
          $location.path('apps/details/'+ portlet.fname);
          $scope.initialFilter = '';
          $scope.showSearch = false;
          $scope.showSearchFocus = false;
        Severity: Major
        Found in web/src/main/webapp/my-app/search/controllers.js and 1 other location - About 1 hr to fix
        web/src/main/webapp/my-app/search/controllers.js on lines 64..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  if ($scope.initialFilter != '') {
            $location.path('apps/search/'+ $scope.initialFilter);
            $scope.initialFilter = '';
            $scope.showSearch = false;
            $scope.showSearchFocus = false;
        Severity: Major
        Found in web/src/main/webapp/my-app/search/controllers.js and 1 other location - About 1 hr to fix
        web/src/main/webapp/my-app/search/controllers.js on lines 56..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status