Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js

Summary

Maintainability
F
4 days
Test Coverage

File 2d-shape-manipulations.js has 666 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var urlParameters = require('../../../js/third-party/url-parameters.js');

// ########################################################################## //
/* Configs (in alphabetical order) */
Severity: Major
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 1 day to fix

Function runEnterHandler has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

function runEnterHandler() {
    var activeElement = document.activeElement;
    var id = activeElement.id;
    var nextElementId = '';
    var elementVariable1;
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerOnBlurEvents has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function registerOnBlurEvents() {
    $('#p0-input-x').on('blur', function() {
        coordTab('c0', 'x');
    });
    $('#p0-input-y').on('blur', function() {
Severity: Major
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 3 hrs to fix

Function registerOnFocusEvents has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function registerOnFocusEvents() {
    $('#p0-input-x').focus(function() {
        setHighlight('c0');
    });
    $('#p0-input-y').focus(function() {
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 1 hr to fix

Function assembleInterface has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function assembleInterface(config) {
    switch(config) {
        case("coord-scale"):
            config = coord_scale; break;
        case("coord-scale-translate"):
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 1 hr to fix

Function runEnterHandler has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function runEnterHandler() {
    var activeElement = document.activeElement;
    var id = activeElement.id;
    var nextElementId = '';
    var elementVariable1;
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 1 hr to fix

Function setUpInterface has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function setUpInterface() {
    var container = document.getElementById('container');
    var polygon = document.getElementById('dynamic-polygon');
    var targetPolygon = document.getElementById('target-polygon');
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 1 hr to fix

Function matrixOperations has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function matrixOperations(test) {
    var matrixElements = document.getElementById('matrices').children;
    var productMatrix = [];
    for (var i = 0; i < 7; i++) {
        var newPoint = new Point();
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkForMatch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function checkForMatch() {
    var match = true;
    for (var i = 0; i < 7; i++) { // 7 points on shape
        if ((Math.round(currentState.currentPosition[i].x * 100) / 100) != (Math.round(configSettings.TARGET_POSITION[i].x * 100) / 100)) {
            match = false;
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        newPoint.x = ((currPoint.x - interfaceSettings.xIntercept)/interfaceSettings.squareSize) * currentState.scaleMatrix[0] + ((currPoint.y - interfaceSettings.yIntercept)/interfaceSettings.squareSize) * currentState.scaleMatrix[1] * -1;
Severity: Major
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 846..846

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        newPoint.y = ((currPoint.x - interfaceSettings.xIntercept)/interfaceSettings.squareSize) * currentState.scaleMatrix[2] + ((currPoint.y - interfaceSettings.yIntercept)/interfaceSettings.squareSize) * currentState.scaleMatrix[3] * -1;
Severity: Major
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 2 hrs to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 845..845

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ((Math.round(currentState.currentPosition[i].x * 100) / 100) != (Math.round(configSettings.TARGET_POSITION[i].x * 100) / 100)) {
            match = false;
            break;
        }
Severity: Major
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 687..690

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ((Math.round(currentState.currentPosition[i].y * 100) / 100) != (Math.round(configSettings.TARGET_POSITION[i].y * 100) / 100)) {
            match = false;
            break;
        }
Severity: Major
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 683..686

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 62.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var matrix_rotate_translate = {
    "type":     "matrix",
    "title":    gettext("Using Translation to Simplify Rotation"),
    "task":     gettext("To move the shape to the new position, you'll have to translate the tip to the origin, apply the rotation, then translate it back."),
    "start":    "5 12 5 10 7 10 5 5 7 5 9 10 9 12",
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 45 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 91..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var matrix_scale_translate_3 = {
    "type":     "matrix",
    "title":    gettext("Using Translation to Simplify Scaling"),
    "task":     gettext("This time the top left tip of the shape is at<br>(12, 12), so you should translate it to the origin, scale it, then translate it back."),
    "start":    "12 12 12 10 14 10 12 5 14 5 16 10 16 12",
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 45 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 58..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    currentState.translateMatrix[1] = parseFloat(document.getElementById('matrix-' + id + '-translate-row-1-col-0').value) * interfaceSettings.squareSize;
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 858..858

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    currentState.translateMatrix[0] = parseFloat(document.getElementById('matrix-' + id + '-translate-row-0-col-0').value) * interfaceSettings.squareSize;
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 35 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 859..859

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    $(document).on('keypress', function(key) {
        if(key.which == 13) {
            // Enter was pressed
            runEnterHandler();
        }
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 30 mins to fix
csfieldguide/static/js/translation-rotation-interactives/translation-rotation.js on lines 731..736

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var matrix_rotate_scale_translate_2 = {
    "type":     "matrix",
    "title":    gettext("Multiple Transformation Challenge"),
    "task":     gettext("Try moving the shape to the target position by using the two multiplication matrices (one to scale and one to rotate) then translating."),
    "target":   "-11.1 -6.08 -8.26 -8.92 -5.42 -6.08 -1.16 -16.02 1.68 -13.18 -2.58 -3.24 -5.42 -0.4",
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 30 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 42..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var matrix_rotate_scale_translate = {
    "type":     "matrix",
    "title":    gettext("Combining Translation, Scaling and Rotation"),
    "task":     gettext("Try moving the shape to the target position by using the two multiplication matrices (one to scale and one to rotate) then translating."),
    "target":   "11 8 9 8 9 4 4 8 4 4 9 0 11 0",
Severity: Minor
Found in csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js and 1 other location - About 30 mins to fix
csfieldguide/static/interactives/2d-shape-manipulations/js/2d-shape-manipulations.js on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status