Sign upLogin

uccser/cs-field-guide

View on GitHub
Star
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js

Summary

Maintainability
D
3 days
Test Coverage

Function inputIsValid has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function inputIsValid(n, speed, processors, complexity) {
  isValid = true;

  // validation for number of items
  nItems = $('#n-items');
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js - About 2 hrs to fix

Function inputIsValid has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

function inputIsValid(n, speed, processors, complexity) {
  isValid = true;

  // validation for number of items
  nItems = $('#n-items');
Severity: Minor
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function calculateSteps has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

function calculateSteps(n, complexity) {
  var steps;
  if (complexity == 'log') {
    steps = Math.ceil(Mathjs.log(n, 2));
  } else if (complexity == 'linear') {
Severity: Minor
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function calculateSteps has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function calculateSteps(n, complexity) {
  var steps;
  if (complexity == 'log') {
    steps = Math.ceil(Mathjs.log(n, 2));
  } else if (complexity == 'linear') {
Severity: Minor
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js - About 1 hr to fix

Function calculateTimeTaken has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function calculateTimeTaken(complexity, resultForm, n, speed, processors, timeUnits) {
Severity: Minor
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js - About 45 mins to fix

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (isNaN(n) || n < 1 || nTooBigGivenComplexity(n, complexity)) {
    nItems.addClass('is-invalid');
    isValid = false;
    if (isNaN(n) || n < 1) {
      nItemsInvalidMsg.removeClass('d-none');
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 2 other locations - About 3 hrs to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 208..223
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 229..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (isNaN(speed) || speed <= 0 || Mathjs.smaller(DIVISOR_LIMIT, Mathjs.bignumber(speed))) {
    speedInput.addClass('is-invalid');
    isValid = false;
    if (isNaN(speed) || speed <= 0) {
      speedInvalidMsg.removeClass('d-none');
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 2 other locations - About 3 hrs to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 187..202
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 229..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if (isNaN(processors) || processors < 1 || Mathjs.smaller(DIVISOR_LIMIT, Mathjs.bignumber(processors))) {
    processorsInput.addClass('is-invalid');
    isValid = false;
    if (isNaN(processors) || processors < 1) {
      processorsInvalidMsg.removeClass('d-none');
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 2 other locations - About 3 hrs to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 187..202
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 208..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 104.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  $('#processors').on('input', function() {
    processors = $('#processors').val();
    if (inputIsValid(n, speed, processors, complexity)) {
      updateData();
    }
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 2 other locations - About 1 hr to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 58..63
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 64..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  $('#speed').on('input', function() {
    speed = $('#speed').val();
    if (inputIsValid(n, speed, processors, complexity)) {
      updateData();
    }
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 2 other locations - About 1 hr to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 58..63
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 70..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  $('#n-items').on('input', function() {
    n = $('#n-items').val();
    if (inputIsValid(n, speed, processors, complexity)) {
      updateData();
    }
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 2 other locations - About 1 hr to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 64..69
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 70..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  $('input[name=time]').click(function() {
    timeUnits = $('input[name=time]:checked').prop('id');
    if (inputIsValid(n, speed, processors, complexity)) {
      updateData();
    }
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 52..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  $('input[name=result-form]').click(function() {
    resultForm = $('input[name=result-form]:checked').prop('id');
    if (inputIsValid(n, speed, processors, complexity)) {
      updateData();
    }
Severity: Major
Found in csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js and 1 other location - About 1 hr to fix
csfieldguide/static/interactives/algorithm-timer/js/algorithm-timer.js on lines 76..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status